RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEISV have been deprecated since ics. RIL_REQUEST_DEVICE_IDENTITY is suggested to be used instead.

I'd like to take this bug to verify the parcel of RIL_REQUEST_DEVICE_IDENTITY to be added in bug 1222920. Then, we could have better test coverage for bug 1222870.

Hi Edgar, May I have your review for this change? Thanks!

Hi Edgar, May I have your review for this change? Thanks!

Note: in Patch Part2, referred to AOSP implementation, the deviceIdentities can be fetched once radio is available (That means radioState != RADIO_UNAVAILABLE). [1] http://androidxref.com/5.1.1_r6/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/gsm/GSMPhone.java#1435 [2] http://androidxref.com/5.1.1_r6/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/cdma/CDMAPhone.java#1196 [3] http://androidxref.com/5.1.1_r6/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/CommandsInterface.java#43

Comment on attachment 8685771 [details] [diff] [review] Part 1: IDL Interface Changes. Review of attachment 8685771 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobileconnection/interfaces/nsIMobileConnectionService.idl @@ +323,5 @@ > > /** > + * Device Identities, including IMEI, IMEISV, ESN and MEID. > + */ > + readonly attribute nsIMobileDeviceIdentities deviceIdentities; Per offline discussion, please also add a listener to notify the identities is updated. Thank you. ::: dom/mobileconnection/interfaces/nsIMobileDeviceIdentities.idl @@ +21,5 @@ > + * Device IMEISV, which should be 2-decimal digits. > + * > + * Valid if GSM subscription is available. > + * > + * Note: The value might be dummy like "000..." from modem Please revise the commit, IMEISV should be 2-decimal digits.

Set NI for 2.2r+ in feature-b2g.

Comment on attachment 8685771 [details] [diff] [review] Part 1: IDL Interface Changes. Review of attachment 8685771 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobileconnection/interfaces/nsIMobileConnectionService.idl @@ +323,5 @@ > > /** > + * Device Identities, including IMEI, IMEISV, ESN and MEID. > + */ > + readonly attribute nsIMobileDeviceIdentities deviceIdentities; will do ::: dom/mobileconnection/interfaces/nsIMobileDeviceIdentities.idl @@ +21,5 @@ > + * Device IMEISV, which should be 2-decimal digits. > + * > + * Valid if GSM subscription is available. > + * > + * Note: The value might be dummy like "000..." from modem How about "Device IMEI, [presented|formed] in 2-decimal digits"?

Comment on attachment 8685771 [details] [diff] [review] Part 1: IDL Interface Changes. Review of attachment 8685771 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobileconnection/interfaces/nsIMobileDeviceIdentities.idl @@ +21,5 @@ > + * Device IMEISV, which should be 2-decimal digits. > + * > + * Valid if GSM subscription is available. > + * > + * Note: The value might be dummy like "000..." from modem Sorry, I misunderstood the line you suggest to revise. it shall line#25 "Note: The value might be dummy like "000..." from modem" instead.

Comment on attachment 8685772 [details] [diff] [review] (v1) Part 2: Implementation Changes. Review of attachment 8685772 [details] [diff] [review]: ----------------------------------------------------------------- Thank you. ::: dom/mobileconnection/gonk/MobileConnectionService.js @@ +1721,5 @@ > > + notifyDeviceIdentitiesChanged: function(aClientId, aImei, aImeisv, > + aEsn, aMeid) { > + this.getItemByServiceId(aClientId).notifyDeviceIdentitiesChanged( > + new MobileDeviceIdentities(aImei, aImeisv, aEsn, aMeid)); I'd prefer that we create MobileDeviceIdentities in MobileConnectionProvide. ::: dom/system/gonk/ril_worker.js @@ +4772,5 @@ > + meid: result[3] || null, > + }; > + > + this.sendChromeMessage({ > + rilMessageType: "deviceidentities", s/deviceidentities/deviceidentitieschange/

Hi Edgar, May I have your review again for this change? Thanks!

Hi Ben, May I have your review for this change? Thanks!

Comment on attachment 8686535 [details] [diff] [review] (v2) Part 3: Bluetooth Changes. r=btian Review of attachment 8686535 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Comment on attachment 8686535 [details] [diff] [review] (v2) Part 3: Bluetooth Changes. r=btian ># HG changeset patch ># User Bevis Tseng <btseng@mozilla.com> ># Date 1447319040 -28800 ># å 11æ 12 17:04:00 2015 +0800 ># Node ID 85cba98b0b03f12dcad4946c653a57df825c8566 ># Parent 975961db253cde0ddd111bad81c2ae377d874c8b >Bug 1110619 - Part 3: Bluetooth Changes. r=btian > >diff --git a/dom/bluetooth/common/BluetoothRilListener.cpp b/dom/bluetooth/common/BluetoothRilListener.cpp >--- a/dom/bluetooth/common/BluetoothRilListener.cpp >+++ b/dom/bluetooth/common/BluetoothRilListener.cpp >@@ -160,16 +160,22 @@ MobileConnectionListener::NotifyLastKnow > } > > NS_IMETHODIMP > MobileConnectionListener::NotifyNetworkSelectionModeChanged() > { > return NS_OK; > } > >+NS_IMETHODIMP >+MobileConnectionListener::NotifyDeviceIdentitiesChanged() >+{ >+ return NS_OK; >+} >+ > bool > MobileConnectionListener::Listen(bool aStart) > { > nsCOMPtr<nsIMobileConnectionService> service = > do_GetService(NS_MOBILE_CONNECTION_SERVICE_CONTRACTID); > NS_ENSURE_TRUE(service, false); > > nsCOMPtr<nsIMobileConnection> connection;

update patch for v2.2r

https://hg.mozilla.org/integration/b2g-inbound/rev/11cc5726cc2d https://hg.mozilla.org/integration/b2g-inbound/rev/8d957f94e34c https://hg.mozilla.org/integration/b2g-inbound/rev/d308e79cbdbe

and for 2.2r https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/8c712917dc6f

https://hg.mozilla.org/mozilla-central/rev/11cc5726cc2d https://hg.mozilla.org/mozilla-central/rev/8d957f94e34c https://hg.mozilla.org/mozilla-central/rev/d308e79cbdbe