DEFECT DESCRIPTION: "Next action indicator" can't be displayed. REPRODUCING PROCEDURES: 1. Load and execute the test applet "STM08003:SET UP MENU with Next Action Indicator" or STM09003:select item with Next Action Indicator" 2. When the menu is set up and integrated are done by SET, check the next action indicator which are displayed with the list of menu items --> KO. Next action indicator can't be displayed with the list of menu item. EXPECTED BEHAVIOUR: Next action indicator should be interpreted and displayed correctly. reporter's office number: ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: REPRODUCING RATE: For FT PR, Please list reference mobile's behavior:

Hi Sean, Could you please help to check the problem? Thanks!

Hi, I did not see any string shown in the picture like "Set Up Call", "Send SS", "Send USSD", "Send SMS", etc. Could you help to clarify how does Gaia get those strings? Thank you.

Sorry, I think I need to describe more clearly. I did not see any string shown in the picture (like "Set Up Call", "Send SS", "Send USSD", "Send SMS", etc), appear in the log. From Gaia, we need to know where the string provided from and how to show it.

Hi Sean Lee, Me too.I guess it's the problem we have to resolve. We need the strings(like "Set Up Call"...) should be included in command object with property name 'nai'. So, we can show it by element named 'small' easily. In the lab ,I found the detail command including "Next Action indication" strings. =========== 9000 Normal ending of the command Proactive SIM Command, Tag = 'D0', Length = 234 Command Details, Tag = '81', Length = 3 Command Details TLV Command Number 1d Type of Command SET UP MENU Set Up Menu Qualifiers Bits Help Information Available Yes RFU 0000000b .... Items Next Action Indicator [NCR], Tag = '18', Length = 17 Items Next Action Item 1: Next Action Indication SET UP CALL Item 2: Next Action Indication SEND SS Item 3: Next Action Indication SEND USSD Item 4: Next Action Indication SEND SHORT MESSAGE Item 5: Next Action Indication PLAY TONE Item 6: Next Action Indication DISPLAY TEXT Item 7: Next Action Indication GET INKEY Item 8: Next Action Indication GET INPUT Item 9: Next Action Indication SELECT ITEM Item 10: Next Action Indication SET UP MENU Item 11: Next Action Indication Unknown value (28) Item 12: Next Action Indication PERFORM CARD APDU Excess data 31 32 33 81 00

// Raw data: 12-03 07:03:50.847 166 166 I Gecko : -*- RadioInterface[0]: Received message from worker: {"commandNumber":1,"typeOfCommand":36,"commandQualifier":128,"rilMessageType":"stkcommand", "options": 12-03 07:03:50.847 166 166 I Gecko : -*- RadioInterface[0]: Received message from worker: {"commandNumber":1,"typeOfCommand":36,"commandQualifier":128,"rilMessageType":"stkcommand","options":{"title":"NAI incorrect","items":[{"identifier":1,"text":"Call"},{"identifier":2,"text":"SS"},{"identifier":3,"text":"USSD"},{"identifier":4,"text":"SMS"},{"identifier":5,"text":"PlayTone"},{"identifier":6,"text":"Dis.Text"},{"identifier":7,"text":"GetInkey"},{"identifier":8,"text":"GetInput"},{"identifier":9,"text":"Sel.Item"},{"identifier":16,"text":"Set.Menu"},{"identifier":17,"text":"Set.IdleText"},{"identifier":18,"text":"Perf.APDU"},{"identifier":19,"text":"PowerOn "},{"identifier":20,"text":"PowerOff "},{"identifier":21,"text":"GetReaderStaus"},{"identifier":22,"text":"End "},{"identifier":23,"text":"Val 00"},{"identifier":24,"text":"Val FF"}],"presentationType":0,"isHelpAvailable":true,"nextActionList":[16,17,18,19,32,33,34,35,36,37,40,48,49,50,51,129,0]},"rilMessageClientId":0} // After parsing: {"title":"NAI incorrect", "items":[ {"identifier":1,"text":"Call"}, 16 : SET UP CALL {"identifier":2,"text":"SS"}, 17 : SEND SS {"identifier":3,"text":"USSD"}, 18 : SEND USSD {"identifier":4,"text":"SMS"}, 19 : SEND SHORT MESSAGE {"identifier":5,"text":"PlayTone"}, 32 : PLAY TONE {"identifier":6,"text":"Dis.Text"}, 33 : DISPLAY TEXT {"identifier":7,"text":"GetInkey"}, 34 : GET INKEY {"identifier":8,"text":"GetInput"}, 35 : GET INPUT {"identifier":9,"text":"Sel.Item"}, 36 : SELECT ITEM {"identifier":16,"text":"Set.Menu"}, 37 : SET UP MENU {"identifier":17,"text":"Set.IdleText"}, 40 : SET UP IDLE MODEL TEXT {"identifier":18,"text":"Perf.APDU"}, 48 : PERFORM CARD APDU {"identifier":19,"text":"PowerOn "}, 49 : POWER ON CARD {"identifier":20,"text":"PowerOff "}, 50 : POWER OFF CARD {"identifier":21,"text":"GetReaderStaus"}, 51 : GET READER STATUS {"identifier":22,"text":"End "}, 129 : End of the proactive session {"identifier":23,"text":"Val 00"}, 0 : {"identifier":24,"text":"Val FF"}], "presentationType":0,"isHelpAvailable":true, "nextActionList":[16,17,18,19,32,33,34,35,36,37,40,48,49,50,51,129,0]},"rilMessageClientId":0}

Hi Pengfei, I've followed 3GPP spec: TS 11.14 13.4 Type of Command and Next Action Indicator to show Next Action Indicator. Please help to test the patch. Thank you.

Hi Sean Lee, We can see the "Next Action" strings, but there is a little problem on UI.And I take screenshots and log, please check. In the method "buildMenuEntry", Is the entry.nai Mozilla designed not for "Next Action" string? If not, maybe we need do translate on "Next Action" strings. Thanks.

Hi Pengfei, Could you provide the icc.js that you merged? I need to confirm whether the patch that I provided got some problems. Thank you.

Hi Fernando, I see there are some NAI related codes implemented by you. Could you help to explain the below questions? 1. Which modules will write menuItem.nai (NAI strings)? 2. TS 11.14 (13.4 Type of Command and Next Action Indicator) shows a table that how to show the corresponding strings from the numbers of nextActionList . Could you tell me where is the implementation of the table ? Thank you!

Please check, Thank you.

Hi Pengfei, There is a line 'a.textContent = entry.text;' in new/icc.js which is deleted in my patch. That's why there is an extra black text shown. Please help to remove the line 'a.textContent = entry.text;' @line528 and test it again. Thank you.

Hi Sean Lee, You are right, I miss the line.:( There is no double menu item string. And a few long "Next Action" strings discover the menu item string like "SET UP IDLE MODEL TEXT". Should we modify the layout of menu item?

Hi Pengfei, Do you mean the long NAI and original menu text will overlap each other? If so, please try the new patch. (the previous one is obsoleted) In this patch, I add a css rule to show a smaller NAI. icc.js part is the same as the previous one. Thanks.

Hi Pengfei, Need your help again. :) I give NAI a better look in this patch. Please help to verify it and see whether it's acceptable. Thank you very much.

Hi Sean Lee, Your patch work very well, test PASS, please check. :) Thanks.

Hi Pengfei, I consider your comments at comment 9, that's a very good point for better i18n support. Here is a patch to make it better, so I need your help to test it again. :) Thank you very much! PS1: Here are 5 new i18n entries: stkItemsNaiPerformCardApdu=Perform Card APDU stkItemsNaiPowerOnCard=Power On Card stkItemsNaiPowerOffCard=Power Off Card stkItemsNaiGetReaderStatus=Get Reader Status stkItemsNaiEndOfTheProactiveSession=End of the proactive session PS2: You can ignore the diff for icc_test.js which is a unit-test code.

Hi Sean Lee, I try your patch. We use navigator.mozL10n.get to translate NAI string, but I found the string was gone. I guess this is a reason why entry.nai not works well , discussing with Shawn by call.

Hi Pengfei, After checking the log, there are couple questions that need your clarification: 1. I see these logs: STK NNNNNNNN: 16,17,18,19,32,33,34,35,36,37,40,48,49,50,51,129,0,255 <<< THIS IS OLD LOG STK NAL: 16,17,18,19,32,33,34,35,36,37,40,48,49,50,51,129,0,255 STK NEXTACTION: SET UP IDLE MODEL TEXT STK Main App Menu item: Perf.APDU # 18 Could you check your icc.js whether it is merged correctly? 2. Per your comment 19, settings.en-US.properties should be verified first. Could you check settings.en-US.properties? Thank you.

Hi Sean, So sorry for my mistake again. I take the screenshots one is Chinese and the other is English(US). I think it works well. Thank you so much.

Hi Pengfei, Thanks for your effort, and NAI looks nice. I will do the code landing process now.

Hi Fernando, I am not sure how the NAI implemented, so there are some quesitons I asked you at comment 11. Before your feedback, I still write a PR for LAB test. If there is any misunderstanding about your code, don't hesitate to point it out. Please help to review it. :) Thank you.

Comment on attachment 8541381 [details] PR for master Hi Arthur, I implement a NAI feature for STK menu in Settings app. Could you help to review this PR? Thank you.

Comment on attachment 8541381 [details] PR for master EJ, could you help review the patch? Thanks!

Comment on attachment 8541381 [details] PR for master Thanks Sean, there are few comments needed to be fixed before giving r+, so please check Arthur and my comments on github ! And by the way, I got one question, although this bug was marked as 2.0m+, are we going to land this patch on the other branches ? It seems that these branches are all affected and has no this feature currently.

Hello EJ, I've updated my PR. Please help to review it again. About your comment 26, master's NAI code is no difference with v2.0m's, so I think both master and v2.0m will need this patch. The only one point needed to be confirmed is that the old NAI design (by Fernando) is changed in my patch. Before discussing with Fernando, we can still land the patch to v2.0m for this emergency case. Thank you.

Comment on attachment 8542090 [details] PR for v2.0m r+, thanks Sean !

Comment on attachment 8541381 [details] PR for master r+ for latest change. @Fernando, please help to answer Sean's question on comment 27, because it seems that interface is changed but there are already some old codes with the same purpose. So, in order not to break anything on master, I think it would be better to have your review on STK part. While for 2.0m, because the schedule is tight and you guys are taking Christmas vacations there, Arthur and I jumped in to help verify this patch. And because this patch has been verified by partner's lab and is only for 2.0m, so we think the change would not affect on other devices (if there is any regression). Hope this brief comment can help you understand what happened here when you were taking days off. Thanks ;)

Thanks, EJ! v2.0m: https://github.com/mozilla-b2g/gaia/commit/688e86b46229e3281beb22fd29f723724eda9df5

Good job Sean! Thank you for the help EJ!

Comment on attachment 8541381 [details] PR for master LGTM

Thanks, Fernando. try-server: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=8cd01498d340 landed on master: https://github.com/mozilla-b2g/gaia/commit/b1eaafaa144013ba41ae04f0a32c6269b4805661

Dear Dengwei, we can close this bug. see bug854599.

Comment on attachment 8541381 [details] PR for master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Next Action Indicator (NAI) feature did not follow the spec at "13.4 Type of Command and Next Action Indicator" in "TS 11.14". This requirement would be failed in LAB test if we did not implement it correctly. [Testing completed]: 1. Implement NAI unit test and test PASS. 2. Partner tested PASS in their LAB. [Risk to taking this patch] (and alternatives if risky): Just to modify the original design to finish the feature. [String changes made]: There are some missing items of NAI did not be added into settings.en-US.properties. We should add them to provide better STK support.

(In reply to Sean Lee [:seanlee] from comment #37) > Comment on attachment 8541381 [details] > PR for master > > [Approval Request Comment] > [Bug caused by] (feature/regressing bug #): > [User impact] if declined: > Next Action Indicator (NAI) feature did not follow the spec > at "13.4 Type of Command and Next Action Indicator" in "TS 11.14". > This requirement would be failed in LAB test if we did not implement it > correctly. > > [Testing completed]: > 1. Implement NAI unit test and test PASS. > 2. Partner tested PASS in their LAB. > > [Risk to taking this patch] (and alternatives if risky): > Just to modify the original design to finish the feature. > > [String changes made]: > There are some missing items of NAI did not be added into > settings.en-US.properties. We should add them to provide better STK support. Its too late to land any string changes on 2.1 at this point, hence we would need another solution or workaround here for this branch...Josh, can you please help go over the string freeze requirement with partner here ? Clearing the approval nom for 2.2 as the patch should already be on that branch given the landing date.

Hi Steven, I think this is only requested by Woodduck partner in 2.0M. Please note that this is only fixed in 2.0M/2.2/'m/c' and you can decide whether to land this on 2.1S if your device partner request it. Thanks!

I believe we need this due to the same partner going to be applied. Vincent, could you help to uplift it to 2.1S? thanks.

[Blocking Requested - why for this release]: Hi Steven, Since status-b2g-v2.1 marked affected, it would be better to cherry pick to v2.1. I can then merge it. v2.1?

I just reread some of the comments. We cannot take this patch in 2.1 if there's any string change + there's a risk to other vendors. Vincent, 2.1+ will affect all vendors and we cannot ask them to take that risk. Please land patches according to other branches (the vendor in question), ie, 2.1M+ and 2.1S+ This is the main reason why we don't want to maintain multiple branches per device.

v2.1s : https://git.mozilla.org/?p=releases/gaia.git;a=commit;h=780546619bb50ef5f36c2f5841298e6a8772b551