Closed
Bug 1114397
Opened 10 years ago
Closed 10 years ago
[Stingray] Use keyboard to move the focus between notification buttons
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
Since the bug 1111414 defined and implemented visual, we should add keyboard support on these buttons.
|
Assignee | |
Comment 1•10 years ago
|
||
Since the dependencies aren't landed, I only put local patch here:
https://github.com/huchengtw-moz/gaia/commit/62b8f65ed51d718e350227ee810eb99f4c38ae84
Once dependencies landed, I will create the PR and request reviewing.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Rex,
This patch handles the buttons navigation by left/right keys. Please review it. To test it, you may need the patch of bug-1111417.
Attachment #8540479 -
Flags: review?(rexboy)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8540479 [details]
use keyboard to navigate notification buttons
Please review this patch. Thanks.
Attachment #8540479 -
Flags: review?(rexboy) → review?(lchang)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8540479 [details]
use keyboard to navigate notification buttons
Looks good but better if adding some comments in the header to describe what the purpose of this module is. (e.g. It only deals with either horizontal or vertical, not both.)
Attachment #8540479 -
Flags: review?(lchang) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/d55d1d5f39bd338ab2d298823aab1121e3d73fef
gaia-try is all green with one known error.
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ec6b3ec9b991
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•