Closed
Bug 1119500
Opened 10 years ago
Closed 10 years ago
Use credentials file for all builds.
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jlund
:
review+
mshal
:
checked-in+
|
Details | Diff | Splinter Review |
In order to upload files to taskcluster, we need the oauth.txt file to supply the credentials. Currently this is missing for at least try builds.
Assignee | ||
Comment 1•10 years ago
|
||
Does this look reasonable? I'm not sure of the best place to turn on use_credentials_file for all builds. I don't think we just want to set use_credentials_file to be True for everything by default yet, just where we need it.
Attachment #8546171 -
Flags: review?(jlund)
Comment 2•10 years ago
|
||
Comment on attachment 8546171 [details] [diff] [review]
use_credentials_file
Review of attachment 8546171 [details] [diff] [review]:
-----------------------------------------------------------------
First, apologies for delay; I was on PTO. I think this is OK. See the notes before landing:
* IIRC, we only pass Buildslaves.py (oauth.txt) to nightlies which don't run on try. Seeing that our try slaves are in a different pool with their own sets of keys, I feel like we are trying to limit the amount of power and knowledge we give our try slaves. I don't see any issues with my tiny brain but we should poll someone like ben or catlee before proceeding.
* this only handles the mozharness build case -- limited to just m-c and all but win64 + xul builds.
Attachment #8546171 -
Flags: review?(jlund) → review+
Comment 3•10 years ago
|
||
>
> * IIRC, we only pass Buildslaves.py (oauth.txt) to nightlies which don't run
> on try. Seeing that our try slaves are in a different pool with their own
> sets of keys, I feel like we are trying to limit the amount of power and
> knowledge we give our try slaves. I don't see any issues with my tiny brain
> but we should poll someone like ben or catlee before proceeding.
>
discussed and confirmed safe here: https://bugzilla.mozilla.org/show_bug.cgi?id=1112252#c16
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8546171 [details] [diff] [review]
use_credentials_file
remote: https://hg.mozilla.org/build/buildbotcustom/rev/c669cd09b150
Attachment #8546171 -
Flags: checked-in+
Comment 5•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/c669cd09b150
Assignee | ||
Comment 6•10 years ago
|
||
AFAIK we can close this now. I'll file followups if necessary.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•