Closed Bug 1119668 Opened 10 years ago Closed 10 years ago

[Flame][Contacts]The delete function in contact details view does not work when you long tap the delete button

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 unaffected, b2g-v2.2 unaffected)

RESOLVED WONTFIX
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- unaffected
b2g-v2.2 --- unaffected

People

(Reporter: lulu.tian, Assigned: ythej)

References

Details

Attachments

(3 files)

Attached file logcat_0513.txt (deleted) —
[1.Description]: According to Bug 1090682 in Comment 27, this bug is filed. [Flame v2.0][Contacts] When you long press the delete button in contact details view, the delect button changes to blue but the delete function does not work. Found time:05:13 See attachment:0513.MP4 and logcat_0513.txt [2.Testing Steps]: 1. Launch Contacts. 2. Tap a contact to check details. 3. Tap edit icon at right top. 4. Slide down and tap(or long press) delete button. [3.Expected Result]: 4. It will pop up the prompt message. [4.Actual Result]: 4. The button changes to blue, but the delete function does not work. [5.Reproduction build]: Flame 2.0 build: Gaia-Rev 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/7c7daab470fb Build-ID 20150108000200 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150108.034549 FW-Date Thu Jan 8 03:46:00 EST 2015 Bootloader L1TC000118D0 Flame 2.1 build: Gaia-Rev ed2e278753e8c9301ba322dcf2c3591f5928408d Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/127a0ead5f83 Build-ID 20150108001214 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150108.040209 FW-Date Thu Jan 8 04:02:21 EST 2015 Bootloader L1TC000118D0 Flame 2.2 build: Gaia-Rev d4dac29613076bdba3cb8adc217deadb08a2ac20 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/70de2960aa87 Build-ID 20150108010221 Version 37.0a1 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150108.044406 FW-Date Thu Jan 8 04:44:17 EST 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: occasionally Recurrence,3/20 [7.TCID]: Free Test [8.Note]: After step 4, tap delete button again, the delete function works well.
Attached video video (deleted) —
Summary: [Flame][Contacts]The delete function in contact details view does not work. → [Flame][Contacts]The delete function in contact details view does not work when you long tap the delete button
Assignee: nobody → yvtheja
Attached file pull request for the bug fix 1119668 (deleted) —
Hi Francisco, Sorry that I couldn't ping you before asking the review.I tried contacting contacts peers at #gaia but I couldn't find them.Please let me know if we need tests for this change. Thank you :)
Attachment #8557871 - Flags: review?(francisco)
Hi Vishnu! Will take a look, you can also can join #fxos-contacts there you'll find all gaia contacts peers too.
Hei Carrie, just a question, should we delete when long pressing, or should we leave the current behaviour?
Flags: needinfo?(cawang)
I think it would be nice if we have this because some fresh user's may have the habit of pressing the button very hard or for long time, it is useful in this case.I can see this case in other platform like android too.(May be my reason is weird). Thanks! :)
Hi Francisco, I'd say "long-tap" = "tap" in this case (in all the cases that we didn't define an action for long-tap to that button). Thanks!
Flags: needinfo?(cawang)
Hi Carrie, after rechecking on the device, we do perform the delete action when we don long press, once we unpress we will perform the action. This patch will make the delete work on the long press before we untap the button. Is that the desired behaviour? Or should we keep it as it is, long tap, and when unpressing the button perform the delete? (Sorry for not explaining on detail)
Flags: needinfo?(cawang)
Hi Francisco, We should keep what it is as in other APPs - performing the action after untapping the button. Thanks!
Flags: needinfo?(cawang)
Hi Carrie, Thanks for your opinion. Hi Francisco, I am doing WONTFIX on the bug. Thanks you !
Flags: needinfo?(francisco)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Thanks, sounds good to me!
Flags: needinfo?(francisco)
Attachment #8557871 - Flags: review?(francisco)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: