### STR 1. Open calendar app 2. Tap new event 3. Enter some words in notes, such as "The zoo" 4. Long press on the message to bring out copy/paste selection menu 5. Tap select all icon ### Actual Copy/paste menu disappeared ### Expected Copy/paste menu stays active ### Version Gaia-Rev f5e481d4caf9ffa561720a6fc9cf521a28bd8439 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/bb8d6034f5f2 Build-ID 20150111160203 Version 37.0a1 Device-Name flame FW-Release 4.4.2 FW-Incremental 65 FW-Date Mon Dec 15 18:51:29 CST 2014 Bootloader L1TC000118D0

This is because if end of element contains a <BR> frame then [1] would exclude this <BR> frame the trigger another selection change event with no reason. Selection carets and bubble will hide if there is a selection change with no reason. [1]: https://dxr.mozilla.org/mozilla-central/source/editor/libeditor/nsPlaintextEditor.cpp?from=nsPlaintextEditor.cpp&case=true#1602

Comment on attachment 8558980 [details] [PullReq] mephisto41:bug1120316-bubble-not-show-when-selectall to mozilla-b2g:master r=gduan. plz merge it after gecko is landed and tbpl is green.

Comment on attachment 8558916 [details] [diff] [review] Batch changes for select all so we don't get selection change with no reason. Review of attachment 8558916 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. If you don't mind, in a separate patch could you move ScopedBatchChanges into its own file or some selection-related header file, and make other callers of Start/EndBatchChanges use it? Thanks!

Updated to review's comment.

Update to reviewer's comment.

Comment on attachment 8559589 [details] [diff] [review] Part 2: Batch changes for select all so we don't get selection change with no reason. Review of attachment 8559589 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!!

Please check-in 2 gecko patches. Thanks.

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment on attachment 8558980 [details] [PullReq] mephisto41:bug1120316-bubble-not-show-when-selectall to mozilla-b2g:master Temporary obsolete this pr because autolander remove my checkin-needed although I just want to checkin my gecko patch...:(

Please check-in 2 gecko patches. Thanks.

Comment on attachment 8559589 [details] [diff] [review] Part 2: Batch changes for select all so we don't get selection change with no reason. NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: After selectall on textarea, user cannot execute cut/copy/paste command. Testing completed: On master Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: Not available

Comment on attachment 8559588 [details] [diff] [review] Part 1: Move SelectionBatcher to Selection.h. NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: After selectall on textarea, user cannot execute cut/copy/paste command. Testing completed: On master Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: Not available

https://hg.mozilla.org/integration/mozilla-inbound/rev/5700863de033 https://hg.mozilla.org/integration/mozilla-inbound/rev/02a3730ec501

https://hg.mozilla.org/mozilla-central/rev/5700863de033 https://hg.mozilla.org/mozilla-central/rev/02a3730ec501

merged to gaia: https://github.com/mozilla-b2g/gaia/pull/28044

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a7f1c2f6cfc https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a93f95370171 v2.2: https://github.com/mozilla-b2g/gaia/commit/726070a69c59869a0b08b74974088c52777e45a4

This issue is verified fixed on Flame Master and 2.2. Result: The text selection menu stays after selecting the select all button. Device: Flame Master (KK, 319mb, full flash) Build ID: 20150319010201 Gaia: c39e15f631de80c69467fda0d4ea0bcda9e194ca Gecko: cf1060d8ce9f Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Device: Flame 2.2 (KK, 319mb, full flash) Build ID: 20150319002500 Gaia: 9043c11f699c15bb6072422d1dad6518d1b5ddda Gecko: c0442d170bec Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429 Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0