Closed Bug 1122425 Opened 10 years ago Closed 10 years ago

[Stingray] UI-Transition - Edit mode Delete card (simplified animation)

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

References

Details

Attachments

(1 file)

Animation when the app is deleted from home in edit mode
Blocks: 1129808
Assignee: nobody → suchiu
Summary: [Stingray] UI-Transition - Edit mode Delete card → [Stingray] UI-Transition - Edit mode Delete card (simplified animation)
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master 1. This patch adds delete card function according to our UI/UX spec (including animations, please watch the video). However, it only implements dropping animation when a card is deleted. More complicate animation will be done in Bug 1149458. 2. Add modal dialog when delete button is pressed. 3. Card dropping animation when deleting. 4. Add bower components smart-dialog and smart-bubbles
Attachment #8586570 - Flags: review?(rexboy)
Attachment #8586570 - Flags: review?(im)
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master Please see my comments at PR. Thanks.
Attachment #8586570 - Flags: review?(im)
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master I still think we may need to make modal dialog an independent shared library in some way (or bower components). This is not a high priority item so you can try it when you are available.
Attachment #8586570 - Flags: review?(rexboy)
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master Hi John and Rex, Modal dialog is changed to smart modal dialog now, please help me to review this patch again. Thanks!
Attachment #8586570 - Flags: review?(rexboy)
Attachment #8586570 - Flags: review?(im)
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master Looks good to me but see my comments for some improvement.
Attachment #8586570 - Flags: review?(rexboy) → review+
And we may need to open a bug (not sure about the priority through) for full animation of deleting card.
Yifan has already opened the following bug 1149458 commented above.
Comment on attachment 8586570 [details] [gaia] sean2449:Bug_1122425-delete-card > mozilla-b2g:master Looks good to me.
Attachment #8586570 - Flags: review?(im) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Component: Gaia → Gaia::TV
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: