+++ This bug was initially created as a clone of Bug #1122433 +++ Expression closures (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Expression_closures) are a nonstandard language extension we'd like to remove from SpiderMonkey. In browser/components/places/content/browserPlacesViews.js, this affects the following getters: get viewElt() this._viewElt, get associatedElement() this._viewElt, get controllers() this._viewElt.controllers, get place() this._place, get result() this._result, get options() this._options, get controller() this._controller, get selType() "single", get hasSelection() this.selectedNode != null, get draggableSelection() [this._draggedElt], get ownerWindow() window, The general pattern for getters is that: get x() y, needs to be replaced with: get x() { return y; },

Hi, I have created a patch which I believe addresses the issue.

Comment on attachment 8550664 [details] [diff] [review] browserPlacesViews.js Hi! This is not a patch, it's the entire modified file. Please use hg diff.

Thanks, I have tried again. Please see the attachment.

Comment on attachment 8550706 [details] [diff] [review] name.patch1 Yep, this is better. Please add a semicolon after each return statement, then this is good to go.

Thanks, I have added in the semicolons.

Thanks! https://hg.mozilla.org/integration/fx-team/rev/32b397321889