Open
Bug 1127555
Opened 10 years ago
Updated 2 years ago
Convert tests to use oomAfterAllocations() instead of gcparam("maxBytes")
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
NEW
People
(Reporter: jruderman, Unassigned)
References
Details
Some tests have gadgets like:
gcparam('maxBytes', gcparam('gcBytes'));
gcparam("maxBytes", gcparam("gcBytes") + 4*1024);
The tests should be changed to use oomAfterAllocations to make them:
* more portable
* more reliable (in regression testing)
* more likely to result in stable testcases (in fuzz testing)
https://dxr.mozilla.org/mozilla-central/search?q=gcparam+maxBytes+gcBytes&case=true&redirect=true
Comment 1•10 years ago
|
||
The problem I see with oomAfterAllocation, is that the test case focus is lost as soon as somebody else add another allocation in-between.
I wish we had some way to taint/annotate allocations to make oomAfterAllocation even more stable.
Reporter | ||
Comment 2•10 years ago
|
||
Isn't that a problem for the maxBytes gadget as well?
Comment 3•10 years ago
|
||
(In reply to Jesse Ruderman from comment #2)
> Isn't that a problem for the maxBytes gadget as well?
Yes, it is. The major difference is that we have more control over the likely allocation which is going to OOM. (not for what you reported in comment 0)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•