Closed Bug 1127648 Opened 10 years ago Closed 8 years ago

[Messages] Attachment can be selected, caret appears

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 affected, b2g-master affected)

RESOLVED WONTFIX
Tracking Status
b2g-v2.2 --- affected
b2g-master --- affected

People

(Reporter: ericcc, Unassigned)

References

Details

(Whiteboard: [2.2-CP-bug-bash])

Attachments

(3 files)

Attached image 2015-01-30-09-41-45.png (deleted) —
*** Steps to Reproduce 1. Put some text in compose pane. 2. Attach a video or music *** Expected Results Attachment cannot be selected *** Actual Results Attachment can be selected *** Reproduction Frequency: 100% *** Version Serial: e47cd843 (State: device) Build ID 20150129003432 Gaia Revision 6e494f1d2676d231abba7dcc2e2822d1170d2d02 Gaia Date 2015-01-29 06:34:56 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5e6fac01a72f Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150129.042943 Firmware Date Thu Jan 29 04:29:53 EST 2015 Bootloader L1TC000118D0
QA Whiteboard: [COM=Gaia::Messages]
Triage: do we need to fix this for v2.2?
blocking-b2g: --- → 2.2?
Triage: Attachment can't be pasted in any other app. Hence, this new functionality is broken. Marking this bug as a blocker.
blocking-b2g: 2.2? → 2.2+
Also occurring in master so marking "status-b2g-v3.0" as affected. Environmental variables: Flame 3.0 device Build Id: 20150130082956 Gecko: 8e96000 Gaia: 21829dd Platform version: 38.0a1
Blocks: CopyPasteGaia
No longer blocks: CopyPasteLegacy
QA Whiteboard: [COM=Gaia::Messages] → [COM=Gaia::SMS]
Attached file Link to github (deleted) —
Firstly I thought maybe setting the user-select: none to attachment might work but in vain. Hi George, could you please help verify it's gecko or gaia work? I also did some experiment in range selection from gaia POV, the selection range looks correct, but the careat and copy paste bubble didn't show up(but it's weird that scrolling or touching the screen will force them display), maybe only selectAllChildren could trigger the copy paste, but we'll also need more information about this behavior.
Attachment #8559640 - Flags: feedback?(gduan)
Thank to reporting this bug. I think this should be fixed in gecko, file bug 1130297 for it.
Depends on: 1130297
Hi Omega, any comment about this behavior?
Flags: needinfo?(ofeng)
Generally in any web pages, user can select an image and do "Copy" action on it (however, in v2.2, the image won't be put into clipboard). In Messages app, IMO, it would be fine to be consistent with general web pages, but I still ni? Messages UX owner Jenny for comments.
Flags: needinfo?(ofeng) → needinfo?(jelee)
Ideally, we can actually copy an image and paste it. But it's ok we follow how text selection currently works (unable to copy) and fix it in future version. Thanks!
Flags: needinfo?(jelee)
So, now that bug 1130297 has been marked as invalid, what's the path forward? From the attachment, the attachment has no "blue" overlay and so I think it stays quite clear it's not selected. NI Jenny, Johan: do you think the current behavior is good enough for v2.2? Renominating as I don't think it should be a bloker.
blocking-b2g: 2.2+ → 2.2?
Flags: needinfo?(jlorenzo)
Flags: needinfo?(jelee)
I think current behavior is good enough for v2.2. Thanks!
Flags: needinfo?(jelee)
If it's consistent across the rest of the OS, the current behavior looks okay to me. Leaving the nom for the triage team to make the final call on it.
Flags: needinfo?(jlorenzo)
Triage team: According to comments 11 and 12 removing the nomination. Please ask for approval if the patch is simple.
blocking-b2g: 2.2? → ---
QA Whiteboard: [COM=Gaia::SMS] → [COM=Gaia::SMS][COM=Text Selection]
The current behavior seemed ok for 2.2, but should we improve it as per comment #9? Cannnot contact Jenny, so ni ux team, thanks
Flags: needinfo?(firefoxos-ux-bugzilla)
(In reply to Isabel Rios[:isabel_rios] from comment #14) > The current behavior seemed ok for 2.2, but should we improve it as per > comment #9? > Cannnot contact Jenny, so ni ux team, thanks Jenny has already left Mozilla, current SMS UX guy is Bryant :)
Flags: needinfo?(bmao)
I imagined that...Thanks Oleg for addressing it to the correct person :)
Flags: needinfo?(firefoxos-ux-bugzilla)
Please ref Bug 1201313 that we're still waiting for PM's call to decide how we deal with the image pasting feature in the next release.
Flags: needinfo?(bmao)
QA Whiteboard: [COM=Gaia::SMS][COM=Text Selection] → [COM=Gaia::SMS][COM=Text Selection][Low_QA]
QA Whiteboard: [COM=Gaia::SMS][COM=Text Selection][Low_QA] → [COM=Gaia::SMS][COM=Text Selection]
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: