Closed Bug 1128916 Opened 10 years ago Closed 10 years ago

Inline article images are not aligned properly in reader mode on desktop

Categories

(Toolkit :: Reader Mode, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1146373

People

(Reporter: designakt, Assigned: Margaret, Mentored)

References

Details

Attachments

(1 file)

Attached image comparison SUMO article & reader mode (deleted) —
The new reader mode for desktop currently does not show any of the images present in an article. As some articles rely on the attached images this makes reading the article quite difficult. An example are SUMO Articles that reference parts of the UI. e.g.: https://support.mozilla.org/en-US/kb/where-firefox-hello-button
Component: General → Reader Mode
Product: Firefox → Toolkit
Does this also happen in Firefox for Android?
SUMO uses a responsive design which makes testing Firefox for Android tricky at best. We don't try to parse mobile designed pages.
(In reply to Kevin Brosnan [:kbrosnan] from comment #2) > SUMO uses a responsive design which makes testing Firefox for Android tricky > at best. We don't try to parse mobile designed pages. That's not true, we do parse mobile designed pages. I just tested this myself, and we do indeed show images in the Android reader mode view, so whatever is going on here is definitely desktop specific. I actually don't think this is a Readability issue then, it seems like an issue with the desktop logic to display a page.
Blocks: desktop-reader
No longer blocks: fix-readability
P2 based on this being a broader issue than just SUMO. I've also noticed it not loading right images.
Blocks: fix-readability
No longer blocks: desktop-reader
Priority: -- → P2
Summary: (desktop-reader) article images are not shown in reader mode → article images are not shown in reader mode on desktop
Could someone bring a reproducible sample test case? A URL is enough.
Trying to reproduce this now, I do see the images appear, but they aren't aligned properly with the text. Looks like we should just remove the bottom margin from inline images in reader view. This isn't a Readability issue, though.
Blocks: desktop-reader
No longer blocks: fix-readability
Summary: article images are not shown in reader mode on desktop → Inline article images are not aligned properly in reader mode on desktop
Flags: qe-verify+
Assignee: nobody → margaret.leibovic
This should be fixed by bug 1146373.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: