Open Bug 1130209 Opened 10 years ago Updated 2 years ago

[Mac] Get rid of the padding above the tabs when in full screen mode on OS X 10.10

Categories

(Firefox :: Toolbars and Customization, defect)

38 Branch
x86_64
macOS
defect

Tracking

()

People

(Reporter: phlsa, Unassigned)

References

Details

Since Yosemite now shows another header bar underneath the menu bar in full screen mode, we can't keep the tab titles visible when the menu bar is showing. So there's little reason to keep the space above the tabs. Maximized mode on Windows is the reference here for what the spacing should look like.
(In reply to Philipp Sackl [:phlsa] please use needinfo to make me respond from comment #7) > (In reply to :Gijs Kruitbosch from comment #6) > > (In reply to Dietrich Ayala (:dietrich) from comment #5) > > > (In reply to Philipp Sackl [:phlsa] please use needinfo from comment #4) > > > > We should get rid of the additional padding in full screen mode though. I > > > > believe there's a bug for this somewhere. > > > > > > Great idea Philipp, what's the bug number? > > > > I couldn't find one. However, when I went to file one, I noticed that we > > have several bugs on file that were fixed that *added* this space, because > > otherwise, in fullscreen mode, the menubar appears all the time when trying > > to navigate between tabs with the mouse, and then overlaps most of the tabs > > and ends up being very annoying. > > > > I'm not really sure we can fix one without breaking the other. Philipp? > > Since Yosemite now shows another header bar underneath the menu bar in full > screen mode, we can't keep the tab titles visible anyway (unless we make our > entire chrome shift down like Safari does, which would be the best way to > handle this). So I think as Yosemite gains adoption, we can safely get rid > of the space. I don't understand. This header bar is not permanent - not on mavericks, not on yosemite. The space is there so mousing up doesn't immediately trigger the header+menubar rolling over the tabs. I don't see how yosemite changes anything here.
Flags: needinfo?(philipp)
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
Interesting, I've never seen the space as a protection from activating the menu bar accidentally. I thought the purpose was that the tab title is still somewhat visible, even when the bar is triggered. I tried removing the space using devtools and working with it for a while. Worked fine for me, but I'm just one data point. How about landing it in Nightly and seeing how the feedback is?
Flags: needinfo?(philipp)
Hm, well, see bug 714186 which added this. I have little opinion here, I almost never use fullscreen anyway. In any case, it seems like that bug should be taken into account, and then maybe we want to reverse course by fixing this bug, I guess.
Blocks: 714186
Flags: needinfo?(shorlander)
Flags: needinfo?(philipp)
(I am skeptical about "land it in Nightly and see what kind of feedback we get" because I don't think we have great OSX fullscreen coverage on Nightly, and because it's currently hard to keep track of incoming bugs regarding a specific thing without killing your inbox entirely)
From my perspective I don't feel like anything has changed here. The space was inserted as a way to limit too much accidental activation of the menubar, which is still an issue AFAICT.
Flags: needinfo?(shorlander)
How about this: We could extend the clickable area of the tabs all the way to the top of the screen. That way we don't lose the space, but we still get the Fitts-law-advantage when clicking quickly.
Flags: needinfo?(philipp)
(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #7) > How about this: We could extend the clickable area of the tabs all the way > to the top of the screen. > That way we don't lose the space, but we still get the Fitts-law-advantage > when clicking quickly. WFM but I expect that is non-trivial to implement.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.