Closed
Bug 1131338
Opened 10 years ago
Closed 10 years ago
Search app should use short_name for apps when available
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: djabber, Assigned: daleharvey)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
The search app displays matches to local application and bookmarks.
Each result shows an icon and a label. The label should display the short_name for the app if possible.
Comment 1•10 years ago
|
||
Thanks for clarifying Francis.
I suspect that you should also be able to search for an app by its short name? That might be trickier...
Flags: needinfo?(fdjabri)
Updated•10 years ago
|
feature-b2g: --- → 2.2+
Whiteboard: [systemsfe]
Reporter | ||
Comment 2•10 years ago
|
||
I agree that you should be able to search for an app by it's search name, especially as this is what the user will see.
Flags: needinfo?(fdjabri)
Updated•10 years ago
|
blocking-b2g: --- → 2.2+
feature-b2g: 2.2+ → ---
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8568457 -
Flags: review?(kgrandon)
Comment 5•10 years ago
|
||
Comment on attachment 8568457 [details]
[gaia] daleharvey:1131338 > mozilla-b2g:master
This looks good to me, thanks!
Attachment #8568457 -
Flags: review?(kgrandon) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/0d7a58253fe20c230de647865cb5a6d0afc6c376
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•10 years ago
|
||
Hermes, any reason you are needinfo'ing me as opposed to asking for approval? I dont think it makes a difference if this hits 2.2, I dont think there is a case where the short_names differ from the long names currently.
Flags: needinfo?(dale)
Comment 9•10 years ago
|
||
(In reply to Dale Harvey (:daleharvey) from comment #8)
> Hermes, any reason you are needinfo'ing me as opposed to asking for
> approval? I dont think it makes a difference if this hits 2.2, I dont think
> there is a case where the short_names differ from the long names currently.
Dale, sorry about that, but as a QA, I should not ask for landing approval on behalf of developers. Besides, this bug blocks 2.2, so it should be uplifted. Please let me know if you have any concerns. Thank you.
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8568457 [details]
[gaia] daleharvey:1131338 > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Feature
[User impact] if declined: Little
[Testing completed]: Automated tests added
[Risk to taking this patch] (and alternatives if risky): Little Risk
[String changes made]:
Attachment #8568457 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Flags: needinfo?(bbajaj)
Attachment #8568457 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Updated•10 years ago
|
Target Milestone: --- → 2.2 S8 (20mar)
Comment 12•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Target Milestone: 2.2 S8 (20mar) → 2.2 S7 (6mar)
Comment 13•10 years ago
|
||
verified with below build:
* 2.2
Build ID 20150326164141
Gaia Revision 6d0174e28576f2f93e696a43d1ac3b03340117f6
Gaia Date 2015-03-26 21:47:33
Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/820c2f2e817a
Gecko Version 37.0
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150326.201153
Firmware Date Thu Mar 26 20:12:05 EDT 2015
Bootloader L1TC000118D0
* master
Build ID 20150326160206
Gaia Revision 525c341254e08f07f90da57a4d1cd5971a3cc668
Gaia Date 2015-03-26 16:34:16
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/59554288b4eb
Gecko Version 39.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150326.193247
Firmware Date Thu Mar 26 19:32:58 EDT 2015
Bootloader L1TC100118D0
* Test App URL: http://mozilla-b2g.github.io/qa-testcase-data/hermescheng/short_name-support/index.html
You need to log in
before you can comment on or make changes to this bug.
Description
•