We should have support to take pictures in the app when the Camera button is pressed.

So, the Gecko part is about to land, and we are exposing this new button as "MozCameraFocusAdjust". My PR was updated accordingly.

Comment on attachment 8565943 [details] [gaia] lissyx:bug1133965 > mozilla-b2g:master Looks good! Not sure we need to keyUp handler. Whilst you're at it can you call .capture() when the volume up/down key is pressed too?

Wilson, I've updated my PR according to your feedback. I just have one question: should those be tested in apps/camera/test/unit/controllers/camera_test.js or is there a better place?

(In reply to Alexandre LISSY :gerard-majax from comment #4) > Wilson, I've updated my PR according to your feedback. I just have one > question: should those be tested in > apps/camera/test/unit/controllers/camera_test.js or is there a better place? Yep, that should be a good place for the unit-tests :)

green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=899dc565a80c

Comment on attachment 8582364 [details] [gaia] wilsonpage:1133965-v2.2 > mozilla-b2g:v2.2 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Volume rocker will toggle volume and not capture [Testing completed]: [Risk to taking this patch] (and alternatives if risky): New feature, moderate risk. [String changes made]: None

(In reply to Wilson Page [:wilsonpage] from comment #9) > Comment on attachment 8582364 [details] > [gaia] wilsonpage:1133965-v2.2 > mozilla-b2g:v2.2 > > [Approval Request Comment] > [Bug caused by] (feature/regressing bug #): > [User impact] if declined: Volume rocker will toggle volume and not capture > [Testing completed]: > [Risk to taking this patch] (and alternatives if risky): New feature, > moderate risk. > [String changes made]: None I'd apply the same reasoning for not approving this as : https://bugzilla.mozilla.org/show_bug.cgi?id=1137918#c9. Also Aries/Shinano will be using our master/central builds so don't think there is value in pushing this on 2.2. please Ni, If I've got anything wrong here.

Removing blocking bug nomination. We are past the feature landing phase of the 2.2 release. Please land on master and this will be picked up in the post 2.2 release train Thanks Hema