Closed Bug 1138123 Opened 10 years ago Closed 10 years ago

libxpcomsample.so should not be listed in components.manifest

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla39
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
firefox37 --- wontfix
firefox38 --- wontfix
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: darktrojan, Assigned: froydnj)

References

Details

(Whiteboard: [caf priority: p2][CR 802466])

Attachments

(1 file)

remove xpcom/sample/ as a bygone relic
(deleted), patch
benjamin
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
See also bug 589666. libxpcomsample.so is listed in components/components.manifest, and causes this log message: > Failed to load native module at path '/opt/firefox-nightly/components/libxpcomsample.so': (80004005) /opt/firefox-nightly/components/libxpcomsample.so: cannot open shared object file: No such file or directory
I am seeing the same issue on FFOS as well. Changing XPCOMBinaryComponent at [1] to GeckoSharedLibrary fixes the issue. [1] https://dxr.mozilla.org/mozilla-central/source/xpcom/sample/moz.build#34
Blocks: CAF-v2.2-metabug
Whiteboard: [CR 802466]
Whiteboard: [CR 802466] → [caf priority: p2][CR 802466]
blocking-b2g: --- → 2.2?
Hi Nathan, Can you help find an owner for this issue that's blocking CAF's fxOS FL milestone? I'm needinfo'ing you since you're listed as XPCOM owner[1]. Thanks, Mike [1] https://wiki.mozilla.org/Modules/All#XPCOM
Flags: needinfo?(nfroyd)
This is a build system problem. But how is it blocking anything? It's a warning that has been around for, like, ever.
Component: XPCOM → Build Config
Flags: needinfo?(nfroyd)
It's useless junk that is happening during the startup of every app, and the fix appears to be trivial. I guess if app start time was meeting the goal then we wouldn't care.
The only trivial fix would be to remove xpcom/sample. Considering how xpcom/sample/xpconnect-sample.html is outdated and likely doesn't work, that doesn't seem like far fetched. Benjamin, what do you think?
Flags: needinfo?(benjamin)
triage: according to the guideline[1] this shouldn't block. But i'm leaving the nom for now to see if there's more input. [1] https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines
Yes, let's remove xpcom/sample, it has outlived its usefulness.
Flags: needinfo?(benjamin)
I love the smell of deleted code in the morning.
Attachment #8574702 - Flags: review?(benjamin)
Attachment #8574702 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d130160317fa
Assignee: nobody → nfroyd
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/d130160317fa
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
This bug could only have been better if there had been one or more Perl scripts among the removed files.
I am fine to uplift this on b2g37 given its really low risk, without blocking on this as I do not see this being a critical release blocker.
blocking-b2g: 2.2? → -
Comment on attachment 8574702 [details] [diff] [review] remove xpcom/sample/ as a bygone relic We'd like the stale code smell removed from v2.2 as well please. :)
Attachment #8574702 - Flags: approval-mozilla-b2g37?
Attachment #8574702 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Blocks: CAF-v3.0-FL-metabug
No longer blocks: CAF-v3.0-FL-metabug
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: