We can do this as a simple drop-in replacement once we have EnumeratedRange (bug 1142999).

I had to add braces in a few instances to appease MSVC. I'm not sure what the exact problem is, but I think it's something like for (auto i : foo()) do { // do stuff } while(0); that it doesn't like, where the do-while is part of MOZ_ASSERT().

Rebased somewhat, including on top of 1143966. I also had to add #ifdef DEBUG around one for loop that only contained an assertion, since with a range-based for loop the assertion was the only use of the variable (unlike a regular for loop, where the header itself uses the variable)! This was causing warn-as-err opt builds to burn. https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e3b2557b22 (I think OSX is experiencing some infra failure - other try jobs appear similarly affected)

Comment on attachment 8581193 [details] [diff] [review] v1.1 - Switch AllocKind iteration over to range-based for loops. Review of attachment 8581193 [details] [diff] [review]: ----------------------------------------------------------------- \o/

This needs to land along with or after bug 1142999, but it shouldn't matter in which order you apply them.