Closed
Bug 1144081
Opened 10 years ago
Closed 10 years ago
Some buttons and menus (if drawInTitlebar is true) now require a double click to function
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox39 | + | verified |
People
(Reporter: streetwolf52, Assigned: dvander)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150316163014
Steps to reproduce:
1. Install LastPass for Firefox.
2. Insure LP button is on a toolbar, Nav, Bookmarks for example.
Actual results:
Hovering over the button does not produce a hover color nor does clicking on the button bring up the LP context menu. Now you have to double-click to use the button.
Expected results:
LP button should have a hover color when pointer is placed over it. A single click should be all that is needed to bring up the context menu.
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
So the range is:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ff27f90ed289&tochange=24640e5e0d3d
You posted in bug 1142814 but bug 1143567 seems more likely...
Reporter | ||
Comment 3•10 years ago
|
||
When I go to the 'bad' cset all I see is the one patch. How do I see the other patches that fall within this cset?
Comment 4•10 years ago
|
||
Construct a URL like so: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ff27f90ed289&tochange=24640e5e0d3d with the fromchange being the "good" and tochange being the "bad"
[Tracking Requested - why for this release]:
status-firefox38:
--- → unaffected
tracking-firefox39:
--- → ?
Reporter | ||
Comment 6•10 years ago
|
||
Just discovered that the options button (to the left of the search box) on about:addons also requires a double click whereas before a single click opened up the context menu. I'm sure their are other buttons similarly affected.
Reporter | ||
Comment 7•10 years ago
|
||
The Back/Forward buttons now require a double click to work as well as having no hover color.
Reporter | ||
Updated•10 years ago
|
Summary: LastPass button now requires a double click to function. → Some buttons now require a double click to function.
Reporter | ||
Comment 8•10 years ago
|
||
Just one more for you. The search engine buttons on the search bar also require a double click.
Tracking for 39.
David, can you take a look since this may be a regression from your patch in bug 1143567. Thanks!
Flags: needinfo?(dvander)
Comment 10•10 years ago
|
||
Confriming and setting to NEW, seeing the same on m-c win7 x64 win32 build.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•10 years ago
|
Summary: Some buttons now require a double click to function. → Some buttons and menus (if drawInTitlebar is true) now require a double click to function
Comment 11•10 years ago
|
||
Last good: http://hg.mozilla.org/integration/mozilla-inbound/rev/59bc41a51a2b
First bads are after bug 1143567 landed. Commits:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1727096f4b48
http://hg.mozilla.org/integration/mozilla-inbound/rev/311dd54d806b
http://hg.mozilla.org/integration/mozilla-inbound/rev/d47ee5553045
http://hg.mozilla.org/integration/mozilla-inbound/rev/5e93ac53e79c
Blocks: 1143567
Assignee | ||
Comment 12•10 years ago
|
||
Accidentally assigned nsEventStatus to bool. Whoops.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Flags: needinfo?(dvander)
Attachment #8578791 -
Flags: review?(jmathies)
Comment 13•10 years ago
|
||
Comment on attachment 8578791 [details] [diff] [review]
fix
(In reply to David Anderson [:dvander] from comment #12)
> Created attachment 8578791 [details] [diff] [review]
> fix
>
> Accidentally assigned nsEventStatus to bool. Whoops.
..and I missed it in the review. whoops x 2.
Attachment #8578791 -
Flags: review?(jmathies) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
status-firefox39:
--- → affected
Assignee | ||
Comment 14•10 years ago
|
||
Keywords: checkin-needed
Comment 15•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment 21•10 years ago
|
||
Right click on the same items is still broken after the respin.
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Comment 22•10 years ago
|
||
Not fixed totally. Now right click on a bookmark does nothing. Actually only single left click fixed
Flags: needinfo?(dvander)
Comment 23•10 years ago
|
||
It's working fine for me. Right-Clicking on a bookmark opens a context menu for me.
You need to log in
before you can comment on or make changes to this bug.
Description
•