Closed Bug 1144478 Opened 10 years ago Closed 6 years ago

File extension of ".eml" is better added to file name used for MaildirStore

Categories

(MailNews Core :: Backend, enhancement)

Product:
MailNews Core
Component:
Backend
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0

People

(Reporter: World, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [maildir][fixed by bug 1259040])

+++ This bug was initially created as a clone of Bug #1135309 +++ File extension of ".eml" is better added to file name used for MaildirStore.
No longer depends on: 1135309
I'd always thought that ".eml" was specific to MS exchange/outlook, but it seems that the common use is for standard "message/rfc822" layout. Yay!
Some thoughts on how this relates to OS search integration (Windows Search and OSX Spotlight): If the maildir message filenames had the '.eml' extension, windows search should be able to index them directly, without the added complication of a .mozmsgs directory (as currently required for mbox). For OSX, the .mozmsgs dir is not stored in the profile, but out in a separate location: ~/Library/Caches/Metadata/Thunderbird/... I'm guessing this is the default location for apps to add data for pickup by Spotlight. Not sure if there's a way to tell spotlight to directly index the maildir in the profile. Worth looking to see what mail.app does. Spotlight knows about .emlx files (native file format for mail.app), but I'm not sure if it knows about .eml files too. No problem if not, as we've already got a Spotlight filter for our .mozeml metadata files - we just make one for .eml too. I wrote myself some notes on the search integration - someone else might find them useful: https://github.com/bcampbell/tb-notes/blob/master/os_search_integration.md
Also, the current maildir->mbox mailstore conversion assumes that all message files in a maildir are integers. Not a big deal, but the conversion will need updating if an extension is added to maildir filenames. see also bug 1472524

Fixed by bug 1259040. We might want to follow-up with getting rid of Windows search integration when maildir is used. There's really no need to store the same file twice now. Ben?

Flags: needinfo?(benc)
Target Milestone: --- → Thunderbird 66.0

I think so, Jorg. I could be wrong, but I don't think the search integration does anything special to make windows index the .mozmsgs dir. So cur should be indexed just fine too.
I think the bulk of the work would be on the GUI side of things? Ideally you'd want the windows search integration options to appear disabled on maildir-based folders.

I think it probably deserves it's own Bug.

Flags: needinfo?(benc)

(In reply to Ben Campbell from comment #3)

Also, the current maildir->mbox mailstore conversion assumes that all
message files in a maildir are integers. Not a big deal, but the conversion
will need updating if an extension is added to maildir filenames.

Moot point now - the patch for bug 1259040 sorts this out.

Blocks: 1519364

(In reply to Ben Campbell from comment #5)

I think it probably deserves it's own Bug.

Indeed, bug 1519364.

Fixed by bug 1259040.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1259040
Whiteboard: [maildir] → [maildir][fixed by bug 1259040]
You need to log in before you can comment on or make changes to this bug.