We can now use the override and final keywords.

This patch was automatically generated using the following script: function convert() { echo "Converting $1 to $2..." find . \ ! -wholename "*/.git*" \ ! -wholename "obj-ff-dbg*" \ -type f \ \( -iname "*.cpp" \ -o -iname "*.h" \ -o -iname "*.c" \ -o -iname "*.cc" \ -o -iname "*.idl" \ -o -iname "*.ipdl" \ -o -iname "*.ipdlh" \ -o -iname "*.mm" \) | \ xargs -n 1 sed -i -e "s/\b$1\b/$2/g" } convert MOZ_OVERRIDE override convert MOZ_FINAL final

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4464790ec4 https://hg.mozilla.org/integration/mozilla-inbound/rev/08912c0b2b5d https://hg.mozilla.org/integration/mozilla-inbound/rev/745287406d9e https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5245b8886d https://hg.mozilla.org/integration/mozilla-inbound/rev/79371ae69603 https://hg.mozilla.org/integration/mozilla-inbound/rev/7c491d4a0e06

https://hg.mozilla.org/mozilla-central/rev/ac4464790ec4 https://hg.mozilla.org/mozilla-central/rev/08912c0b2b5d https://hg.mozilla.org/mozilla-central/rev/745287406d9e https://hg.mozilla.org/mozilla-central/rev/bd5245b8886d https://hg.mozilla.org/mozilla-central/rev/79371ae69603 https://hg.mozilla.org/mozilla-central/rev/7c491d4a0e06

Can we please do this on Aurora as well? The gcc support situation is the same and it's already annoyance on uplifts (and will continue to do so throughout the ESR cycle otherwise).

Sure, I can submit this for approval.

Comment on attachment 8580812 [details] [diff] [review] Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree This change doesn't affect our binaries, it only removes a C++ macro which has been obsoleted by our compiler upgrades, and is mostly generated through a script. Uplifting this will make future uplifts for other bugs easier (see comment 10.)

Comment on attachment 8580812 [details] [diff] [review] Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree I guess this is going to make the life of some people harder (they will just have to revert this change) but as 38 is an esr, we want the uplifts to be as easy as possible.

https://hg.mozilla.org/releases/mozilla-aurora/rev/a20c7910a82f https://hg.mozilla.org/releases/mozilla-aurora/rev/15d231833bde https://hg.mozilla.org/releases/mozilla-aurora/rev/2f1e4ecb55d8 https://hg.mozilla.org/releases/mozilla-aurora/rev/b81a700d1cf9 https://hg.mozilla.org/releases/mozilla-aurora/rev/5f2da0467e96 https://hg.mozilla.org/releases/mozilla-aurora/rev/0f67ff87b8ea

Anyone of you mind updating https://developer.mozilla.org/en-US/docs/Mozilla/C++_Portability_Guide with the new rationale and recommendations?

(In reply to Gian-Carlo Pascutto [:gcp] from comment #15) > Anyone of you mind updating > https://developer.mozilla.org/en-US/docs/Mozilla/C++_Portability_Guide > with the new rationale and recommendations? Done.