Closed
Bug 1146112
Opened 10 years ago
Closed 10 years ago
Several assertions with ruby in grid
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jruderman, Assigned: xidorn)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
###!!! ASSERTION: Something went awry in our block parent calculations: '!aFrame->IsBoxFrame() || itemsToConstruct.AnyItemsNeedBlockParent() == (AnyKidsNeedBlockParent(aFrameItems.FirstChild()) != nullptr)', file src/layout/base/nsCSSFrameConstructor.cpp, line 10457
###!!! ASSERTION: No line layout provided to RubyFrame reflow method.: 'aReflowState.mLineLayout', file src/layout/generic/nsRubyFrame.cpp, line 140
###!!! ASSERTION: huh?: 'pfd->mFrame == aFrame', file src/layout/generic/nsLineLayout.cpp, line 445
|
Reporter | |
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
I guess this probably could also happen with flexbox...
|
|
Assignee | |
Comment 3•10 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8585285 -
Flags: review?(roc)
|
|
Assignee | |
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86_64 → All
Comment on attachment 8585285 [details] [diff] [review]
patch
Review of attachment 8585285 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/nsCSSFrameConstructor.cpp
@@ +10166,5 @@
> + // All types of ruby frames need a block frame to provide line layout,
> + // hence they are always line participant.
> + newItem->mIsLineParticipant = disp->IsRubyDisplayType();
> +
> + if (!disp->IsRubyDisplayType()) {
bool isRuby = disp->IsRubyDisplayType();
newItem->mIsLineParticipant = isRuby;
if (!isRuby) {
Attachment #8585285 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•