(In reply to Jim Blandy :jimb from bug 1024774 comment #165) > ::: toolkit/devtools/server/DeserializedNode.cpp > @@ +165,5 @@ > > + return false; > > + } > > + > > + DeserializedNode &referent = node.getEdgeReferent(*edgep); > > + edges.append(mozilla::Move(SimpleEdge(name, Node(&referent)))); > > It's a pity we have to copy the edge vector like this. Could you file a > follow-up bug to make this iterate over the DeserializedNode's underlying > vector, and have 'settle' build a proper JS::ubi::Edge from the current > element?

Comment on attachment 8683285 [details] [diff] [review] Make DeserializedEdgeRange re-use its referents edge vector Review of attachment 8683285 [details] [diff] [review]: ----------------------------------------------------------------- This looks solid, but I don't claim to know the existing heapsnapshot code that well. If you're having doubts about whether or not this fits into the grand scheme of things, please check with Jim too.