Closed
Bug 1150213
Opened 10 years ago
Closed 10 years ago
Use moz_xmalloc/moz_xrealloc/free following bug 1134920
Categories
(Chat Core :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Not sure where strdup->xstrdup happened, but it seems to be needed too.
Attachment #8587002 -
Flags: review?(clokep)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8587002 [details] [diff] [review]
mozmemfix.diff
Review of attachment 8587002 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me. Thanks for fixing the build!
Attachment #8587002 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
|
|
||
Comment 4•10 years ago
|
||
Hmm...so upon re-reading the newsgroup post it sounds like we're supposed to replace these with just malloc/calloc/realloc/free. [1] (Not the x* versions.)
[1] https://groups.google.com/forum/#!topic/mozilla.dev.platform/ffSQld7olEE
Flags: needinfo?(florian)
|
||
Comment 5•10 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #4)
> we're supposed to replace these with just malloc/calloc/realloc/free.
Yes, please do.
Flags: needinfo?(florian)
|
|
||
Comment 6•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•