This was contentious, so holding off until we get more data.

Has there been any further thought on what could be shown (if JIT-mode on) on frames in the call tree that have optimization data?

The only thing that needs to be shown here is an icon or emblem on the tree entry that takes us to the jit view. Basically "there's more detailed opt info about this frame, click on this to go to it".

Comment on attachment 8624548 [details] [diff] [review] 1150295-opt-icon.patch Review of attachment 8624548 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/performance/modules/widgets/tree-view.js @@ +93,5 @@ > */ > function CallView({ > caller, frame, level, hidden, inverted, > + sortingPredicate, autoExpandDepth, visibleCells, > + enableOptimizations I'd rename this to showOptimizationHint ::: browser/devtools/performance/views/details-js-call-tree.js @@ +50,5 @@ > let options = { > contentOnly: !PerformanceController.getOption("show-platform-data"), > invertTree: PerformanceController.getOption("invert-call-tree"), > + flattenRecursion: PerformanceController.getOption("flatten-tree-recursion"), > + enableOptimizations: recording.getConfiguration().withJITOptimizations, Should do those things with memory prefs too for hiding/showing graphs. Different bug, or has that been done already?

Comment on attachment 8624548 [details] [diff] [review] 1150295-opt-icon.patch Review of attachment 8624548 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/performance/modules/widgets/tree-view.js @@ +93,5 @@ > */ > function CallView({ > caller, frame, level, hidden, inverted, > + sortingPredicate, autoExpandDepth, visibleCells, > + enableOptimizations +1 ::: browser/devtools/performance/views/details-js-call-tree.js @@ +50,5 @@ > let options = { > contentOnly: !PerformanceController.getOption("show-platform-data"), > invertTree: PerformanceController.getOption("invert-call-tree"), > + flattenRecursion: PerformanceController.getOption("flatten-tree-recursion"), > + enableOptimizations: recording.getConfiguration().withJITOptimizations, I'm not sure I follow -- all views use currently selected recording's features to determine what to display

https://hg.mozilla.org/integration/fx-team/rev/95dc0052f410

Rebase issue, landing hotfix https://hg.mozilla.org/integration/fx-team/rev/a452ab15ac37

https://hg.mozilla.org/mozilla-central/rev/95dc0052f410 https://hg.mozilla.org/mozilla-central/rev/a452ab15ac37