Closed
Bug 1151482
Opened 9 years ago
Closed 9 years ago
Dev Edition Theme: Text on Windows URL bar is black with dark background
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
(Whiteboard: [devedition-polish])
Attachments
(1 file)
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=1121543#c2 and https://bugzilla.mozilla.org/attachment.cgi?id=8587906. Most likely the change to a lightweight theme is causing a new selector to apply to the text color.
Assignee | ||
Comment 1•9 years ago
|
||
It's due to this rule [0] in windows/browser.css: #urlbar:-moz-lwtheme, .searchbar-textbox:-moz-lwtheme { background-color: rgba(255,255,255,.8); @navbarTextboxCustomBorder@ color: black; } [0]: https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1137
Assignee | ||
Comment 2•9 years ago
|
||
I don't think there is any reason in particular this property wasn't !important like the others in this block, expect that it wasn't needed. Now that this is a :-moz-lw-theme, we do need it for Windows support.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8588735 -
Flags: review?(gijskruitbosch+bugs)
Comment 3•9 years ago
|
||
Comment on attachment 8588735 [details] [diff] [review] devedition-windows-urlbar.patch Review of attachment 8588735 [details] [diff] [review]: ----------------------------------------------------------------- rs=me, sorry for the (long-weekend-holiday-catchup-induced) delay!
Attachment #8588735 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6c7eb5b4df47
Keywords: checkin-needed
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
https://hg.mozilla.org/mozilla-central/rev/6c7eb5b4df47
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 40
Comment 6•9 years ago
|
||
Thanks guys, the bug is fixed with the latest update.
You need to log in
before you can comment on or make changes to this bug.
Description
•