Closed
Bug 1157
Opened 26 years ago
Closed 26 years ago
AVI and WAV OBJECTs crash again
Categories
(Core Graveyard :: Plug-ins, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
M4
People
(Reporter: Antti.Nayha, Assigned: serhunt)
References
()
Details
(Note: I ran these tests with both the plugins from
Navigator 4.5 PR2 and the old versions from Navigator 3.0.
I changed the plugins by modifying the registry at
"hkey_current_user/software/netscape/netscape
navigator/main/install directory".)
Trouble with AVI and WAV OBJECTs. The following
problems occurred on any OBJECT with the MIME type
"video/x-msvideo" or "audio/wav".
The plugin gets loaded, but the video/audio clip won't play.
When using the plugins from 4.5 PR2, the AVI object is just
an empty space where the previous page shows through.
Clicking right button on the space gives a NPAVI32 menu, but
selecting "Play" or anything else does nothing. When I use
the plugins from Nav3.0, NGLayout crashes immediately on
loading the page!
In the WAV tests, a LiveAudio plugin panel saying "Loading
audio file..." is shown. Clicking on the panel a few times
causes a crash. The behaviour is identical with both plugin
versions.
Here's a sample output from my NGLayout on a WAV object test:
loaded plugin npaudio.dll for mime type audio/wav
result of creating plugin adapter: 0
successfully created plugin instance 01253dd0 for
npaudio.dll, mimetype audio/wav
instance start called
The output is similar in the AVI tests.
Updated•26 years ago
|
Status: NEW → ASSIGNED
Comment 1•26 years ago
|
||
I can't even get to the stage where you're experiencing the bug. I crash when I
call into the initial entry point. The plugin calls NPN_GetJavaEnv(), and since
we no longer support a JRI based LiveConnect, we return NULL. It looks like the
plugin does not handle this correctly.
Can you try your test with a more recent build of NGLayout? Also what is the
exact version of the plugin you're using (I have been using npaudio 1.1.1515)
Summary: AVI and WAV OBJECTs won't play but crash instead → ss:AVI and WAV OBJECTs won't play but crash instead
Reporter | ||
Comment 3•26 years ago
|
||
Right, I ran the tests again with an Nov-18 debug build of NGLayout:
- The WAV test doesn't crash any more. It doesn't matter if I use npaudio.dll
version 1.1.1515 or 1.01. The sound still won't play, though!
- The AVI test crashes immediately on loading the page when using the
npavi32.dll from Nav3.0. It doesn't crash when using the npavi32.dll
from Nav4.5. Again, the video clip won't play either.
Updated•26 years ago
|
Summary: ss:AVI and WAV OBJECTs won't play but crash instead → AVI and WAV OBJECTs won't play but crash instead
Don't forget to implement the attribute TABINDEX for element OBJECT.
Comment 6•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Updated•26 years ago
|
QA Contact: 3849 → 4082
Comment 7•26 years ago
|
||
reassigning to Greg Lynn as QA contact
Antti please try again with recent build of NGLayout, March 5 or later. Code at
time you tried last in November was in early Dev phase. Please enter new
findings with updates to test cases.
Reporter | ||
Comment 9•26 years ago
|
||
OK, I downloaded the March 4th nightly build for Win32 and tried again.
It seems that the build has no support for plugins whatsoever, which
effectively solves the problem for the time being - no plugins, no
crashes. :-)
The viewer just renders a grey box in the place of any audio or video
OBJECT.
Reporter | ||
Comment 10•26 years ago
|
||
Sorry, I meant March 5th build - *not* 4th.
Comment 11•26 years ago
|
||
Leaving bug open to track inclusion of ability to play avi and wav files now
that crash is solved.
Comment 12•26 years ago
|
||
This works for me now.
Reporter | ||
Comment 13•26 years ago
|
||
Update on a March 12th Win32 build:
Viewer now seems to crash on any OBJECT with a MIME type other than
image/gif, image/jpeg or image/png (which render correctly). Audio and
video OBJECTs, too, crash the viewer immediately on loading the page.
Also noteworthy: any OBJECT with no 'type' attribute whatsoever crashes
the build, too.
Updated•26 years ago
|
Summary: AVI and WAV OBJECTs won't play but crash instead → Crash on Object tag with no height or width
Comment 14•26 years ago
|
||
There are a few different bugs going on here:
- bug with no mimetype specified on image content (crash in CSS code)
- bug with no height or width specified on plugin content (crash in webshell)
- bug with no mimetype specified on plugin content (no crash, plugin does not
get loaded, alternative content gets displayed)
Let's concentrate this bug on the second matter and I'll open a separate bug for
the other two (basically problems when no mimetype is specified).
The crash in this case occurs when you go to the above url and then go back to a
previous page. First, you get a precondition violation in
nsParser::OnDataAvailable():
NS_PRECONDITION(((eOnStart==mParserContext->mStreamListenerState)||(eOnDataAvail
==mParserContext->mStreamListenerState)),kOnStartNotCalled);
Then you crash in: nsWebShell::OnConnectionsComplete(). I'm cc'ing rickg so he
can comment on the parser precondition. Also, who owns web shell problems?
NOTE: you might have to go back and forth on the test page more than once to
make it crash.
Comment 15•26 years ago
|
||
There are a few different bugs going on here:
- bug with no mimetype specified on image content (crash in CSS code)
- bug with no height or width specified on plugin content (crash in webshell)
- bug with no mimetype specified on plugin content (no crash, plugin does not
get loaded, alternative content gets displayed)
Let's concentrate this bug on the second matter and I'll open a separate bug for
the other two (basically problems when no mimetype is specified).
The crash in this case occurs when you go to the above url and then go back to a
previous page. First, you get a precondition violation in
nsParser::OnDataAvailable():
NS_PRECONDITION(((eOnStart==mParserContext->mStreamListenerState)||(eOnDataAvail
==mParserContext->mStreamListenerState)),kOnStartNotCalled);
Then you crash in: nsWebShell::OnConnectionsComplete(). I'm cc'ing rickg so he
can comment on the parser precondition. Also, who owns web shell problems?
NOTE: you might have to go back and forth on the test page more than once to
make it crash.
Updated•26 years ago
|
Assignee: amusil → av
Status: ASSIGNED → NEW
Comment 16•26 years ago
|
||
Reassigning to Andrei as he is more familiar with object tag issues.
Comment 17•26 years ago
|
||
Now I can't repro this anymore.
Andrei - can you verify this?
Assignee | ||
Comment 18•26 years ago
|
||
No it does not crash any longer
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 19•26 years ago
|
||
First time I tried URL it crashed on win98 optimized March 17 current build,
apprunner causes invalid page fault in module unknown. (Went to bugzilla, pulled
up bug, clicked on URL to repro and adios application.) Mac and Linux did not
crash but no sound is played. 2nd pass on win98 worked in same fashion as Mac/
Linux, third pass crashed again. Reopening.
Comment 20•26 years ago
|
||
Looks like this only crashes in Apprunner, not viewer.
Andrei has a fix.
Updated•26 years ago
|
Status: REOPENED → RESOLVED
Closed: 26 years ago → 26 years ago
Comment 21•26 years ago
|
||
marking fixed
Comment 22•26 years ago
|
||
Ok, latest M3 build timestamped after 8pm does work, i.e. it does not crash.
Sound still does not play but at least it does not crash. Marking verified.
Reporter | ||
Updated•26 years ago
|
Status: VERIFIED → REOPENED
Summary: Crash on Object tag with no height or width → AVI and WAV OBJECTs crash again
Target Milestone: M3 → M4
Reporter | ||
Comment 23•26 years ago
|
||
AVI and WAV OBJECT are crashing again.
That is, all tests at
http://www.student.oulu.fi/%7esairwas/object-test/audio/ and
http://www.student.oulu.fi/%7esairwas/object-test/video/
crash the Apr 20 Win32 build.
Assignee | ||
Comment 24•26 years ago
|
||
We checked in a fix for a crash which could be related yesterday. Try today's
build. I cannot reproduce the crash.
Reporter | ||
Comment 25•26 years ago
|
||
OK, no crash anymore on April 22th Win32 build.
What is more, the audio/video plug-ins actually work! This is
the first time I've seen them in action. Just impressive.
There's still a problem with unsized video OBJECTs (with no width
and height attributes) - they are not displayed at all - but I'll
file another bug about that as soon as I have created some more
thorough test cases for the issue.
Status: REOPENED → RESOLVED
Closed: 26 years ago → 26 years ago
Assignee | ||
Comment 26•26 years ago
|
||
And assign it to me. Marking this one fixed.
Updated•26 years ago
|
QA Contact: glynn → beppe
Comment 27•26 years ago
|
||
beppe, do you get these(plugin stuff) now?
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 28•26 years ago
|
||
I just tested all 4 audio clip tests and they all work perfectly, used build
1999060108
Comment 29•25 years ago
|
||
don't know if linux is supposed to be able to do avi files, since there is no
place i can specify which app to use for it, but clicking on a link to an avi
file crashes build ID 2000040708. Expected functionality in this case - IF no
player was defined - would be a request to download the file, i believe.
-
How to reproduce:
Went to http://www.wapland.no/art/450.html
Clicked link millennium.avi (about middle down the page)
This happens:
Document http://www.wapland.no/art/450.html loaded successfully
Document: Done (12.044 secs)
Error loading URL http://www.wapland.no/art/450.html
Document: Done (3.454 secs)
Program received signal SIGSEGV, Segmentation fault.
0x40b73156 in NSGetModule ()
(gdb) bt
#0 0x40b73156 in NSGetModule ()
#1 0x40ba853f in NSGetModule ()
#2 0x40eb0d18 in NSGetModule ()
#3 0x40ebe9ba in NSGetModule ()
#4 0x40eaf87d in NSGetModule ()
#5 0x4048f00a in nsWidget::DispatchEvent ()
#6 0x4048ef35 in nsWidget::DispatchWindowEvent ()
#7 0x4048efaa in nsWidget::DispatchFocus ()
#8 0x404934c4 in nsWindow::SetFocus ()
#9 0x401ea5f6 in GlobalWindowImpl::Focus ()
#10 0x404273ab in NSGetModule ()
#11 0x4048f00a in nsWidget::DispatchEvent ()
#12 0x40495641 in handle_toplevel_focus_in ()
#13 0x40545809 in gtk_marshal_BOOL__POINTER ()
#14 0x4057333d in gtk_handlers_run ()
#15 0x40572782 in gtk_signal_real_emit ()
#16 0x405708d5 in gtk_signal_emit ()
#17 0x405a5c9c in gtk_widget_event ()
#18 0x40544a5a in gtk_main_do_event ()
#19 0x404885e8 in handle_gdk_event ()
#20 0x405eefcb in gdk_event_dispatch ()
#21 0x4061cf96 in g_main_dispatch ()
#22 0x4061d561 in g_main_iterate ()
#23 0x4061d701 in g_main_run ()
#24 0x405442f9 in gtk_main ()
#25 0x40481e0a in nsAppShell::Run ()
#26 0x4042563a in NSGetModule ()
#27 0x804b20c in JS_PushArguments ()
#28 0x804b523 in JS_PushArguments ()
#29 0x40300a1b in __libc_start_main (main=0x804b3a0 <JS_PushArguments+7348>,
argc=1, argv=0xbffffa34,
init=0x804938c <_init>, fini=0x804c284 <_fini>, rtld_fini=0x4000ae60
<_dl_fini>, stack_end=0xbffffa2c)
at ../sysdeps/generic/libc-start.c:92
(gdb)
Comment 30•25 years ago
|
||
I'm still getting the problem on the Linux 2000060908 build. The URL is
http:
//www.nizkor.org/ftp.cgi/r/people/z/zundel.ernst/Yecheskeli_Interview/Zundel-
Tsadok-001.avi
The stack trace I get is:
0x2b6fd5c2 in NSGetModule ()
(gdb) where
#0 0x2b6fd5c2 in NSGetModule ()
#1 0x2b737111 in NSGetModule ()
#2 0x2b73701f in NSGetModule ()
#3 0x2bae5825 in NSGetModule ()
#4 0x2baf394a in NSGetModule ()
#5 0x2bae444d in NSGetModule ()
#6 0x2b05d5ca in NSGetModule ()
#7 0x2b05d4ed in NSGetModule ()
#8 0x2b05d569 in NSGetModule ()
#9 0x2b061c2f in NSGetModule ()
#10 0x2ae7a00e in GlobalWindowImpl::Focus ()
#11 0x2ae30d2b in NSGetModule ()
#12 0x2b05d5ca in NSGetModule ()
#13 0x2b064195 in NSGetModule ()
#14 0x2b1176cf in gtk_marshal_BOOL__POINTER ()
#15 0x2b1489a8 in gtk_handlers_run ()
#16 0x2b147d7f in gtk_signal_real_emit ()
#17 0x2b145d37 in gtk_signal_emit ()
#18 0x2b17e61c in gtk_widget_event ()
#19 0x2b1873cb in gtk_window_real_set_focus ()
#20 0x2b11795b in gtk_marshal_NONE__POINTER ()
#21 0x2b147dbd in gtk_signal_real_emit ()
#22 0x2b145d37 in gtk_signal_emit ()
#23 0x2b18464e in gtk_window_set_focus ()
#24 0x2b17f14a in gtk_widget_real_grab_focus ()
#25 0x2b117b63 in gtk_marshal_NONE__NONE ()
#26 0x2b147dbd in gtk_signal_real_emit ()
#27 0x2b145d37 in gtk_signal_emit ()
#28 0x2b17ef98 in gtk_widget_grab_focus ()
#29 0x2b0640b2 in NSGetModule ()
#30 0x2b1176cf in gtk_marshal_BOOL__POINTER ()
#31 0x2b1489a8 in gtk_handlers_run ()
#32 0x2b147d7f in gtk_signal_real_emit ()
#33 0x2b145d37 in gtk_signal_emit ()
#34 0x2b17e61c in gtk_widget_event ()
#35 0x2b1167bb in gtk_main_do_event ()
#36 0x2b0587c8 in NSGetModule ()
#37 0x2b1c85a4 in gdk_event_dispatch ()
#38 0x2b1f3f96 in g_main_dispatch ()
#39 0x2b1f4561 in g_main_iterate ()
#40 0x2b1f4701 in g_main_run ()
#41 0x2b115fdc in gtk_main ()
#42 0x2b05146c in NSGetModule ()
#43 0x2ae2ee3a in NSGetModule ()
#44 0x804d207 in JS_PushArguments ()
#45 0x804d60d in JS_PushArguments ()
#46 0x2acf0fb3 in __libc_start_main (main=0x804d508 <JS_PushArguments+10572>,
argc=1, argv=0x7ffff924, init=0x804a77c <_init>, fini=0x8051d28 <_fini>,
rtld_fini=0x2aab55d0 <_dl_fini>, stack_end=0x7ffff91c)
at ../sysdeps/generic/libc-start.c:78
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•