Closed Bug 1158665 Opened 10 years ago Closed 10 years ago

[Stingray][Home] After a card is added into a folder, align the folder list to the folder card

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yifan, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 files)

1158665_patch.diff
(deleted), patch
Details | Diff | Splinter Review
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master
(deleted), text/x-github-pull-request
dwi2
: review+
yifan
: feedback+
Details
+++ This bug was initially created as a clone of Bug #1117699 +++ In edit mode, after a card is added into a folder, align the folder list to the folder card.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Assignee: tzhuang → yliao
Assignee: yliao → nobody
Status: ASSIGNED → NEW
Attached patch 1158665_patch.diff (deleted) — — Splinter Review
This is the patch that fixes * Add a card into the last position in a folder when a folderScrollobale is reversed. * Align the folderScrollable to the hovered folder in the cardScrollable when a card is added into an empty folder.
Flags: needinfo?(rexboy)
Assignee: nobody → rexboy
Flags: needinfo?(rexboy)
Comment on attachment 8602679 [details] [gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master The patch. Tzu-lin may you help on reviewing this patch? If you are not available I can try changing reviewer. Setting f? to yifan too.
Attachment #8602679 - Flags: review?(tzhuang)
Attachment #8602679 - Flags: feedback?(yliao)
Comment on attachment 8602679 [details] [gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master This looks good to me. Thanks
Attachment #8602679 - Flags: review?(tzhuang) → review+
Attachment #8602679 - Flags: feedback?(yliao) → feedback+
Thanks for the patch!
After discussing with Yifan We found the animation of moving card down to folderScrollable doesn't work as expect when: (1)folder is rearranged and empty (2)folder is at the edge of screen. I'll open follow-up bug for it.
Thanks for taking care of the patch Tzu-lin and Yifan. master: https://github.com/mozilla-b2g/gaia/commit/3692ad2cf3a047cc66f58f655a56b6ec559ef253
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: