The message selection goes up-down, is all weird, messed-up.

Is this related to 65823?

yes, it is related. We can mark this as dup. *** This bug has been marked as a duplicate of 65823 ***

selection is jumping for imap-delete model for multiple deletes, that bug is about selecting non-deleted message which is a minor but this is bad because it jumps to end of the view. I have a fix for this problem.

moving to 0.9.9

Just made it like 4x. multiple deletion will not do anything to selection. The fix is to have js and C++ both use nsMsgViewIndex_None. Also I cleaned up some small things like multiple selection of msgs will setTitle to folder, selectAll will also do the same thing. I did this for standalone and search and for search we will have to know deleteModel if we are to select next msg correctly before we delete the msg. tested standalone, folder w/ one message, replying to msg, search and going back and forth between deleteModels.

cc david for review. I will get seth to sr also.

isn't nsMsgViewIndex_None the same as -1 which is the same as 0xFFFFFFFF? I can't really tell the difference in the patch, except that global variable starts off at -2 instead of -1, but that can't be sufficient to fix this bug.

If you look at nsMsgDBView::GetMsgToSelectAfterDelete we assign msgViewIndex_none in the case of multiple msg deletion and when deletemodel==IMAPDelete js doesn't take nsMsgViewIndex_None as -1, it takes it as 0xFFFFFFF or 427454545 (something like this)

Comment on attachment 68035 [details] [diff] [review] proposed fix r=bienvenu, ok, I think I see.

Comment on attachment 68035 [details] [diff] [review] proposed fix r=bhuvan

fixed