Closed
Bug 1160503
Opened 10 years ago
Closed 10 years ago
[toolkit] In SWW, pass matching parameters to the default offline cache middle ware
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(b2g-master fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: arcturus, Assigned: arcturus)
References
Details
(Whiteboard: [s1])
Attachments
(1 file)
|
Assignee | |
Updated•10 years ago
|
Blocks: nga-toolkit-service-workers
|
|
Assignee | |
Updated•10 years ago
|
QA Contact: francisco
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → francisco
QA Contact: francisco → nobody
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Right now it's a bit fuzzy, since seems Chrome doesn't support the matching options and tests stopped working in Firefox Nightly (even if i run the master branch)
Asking for feedback to check if the solution looks simple
Attachment #8600357 -
Flags: feedback?(salva)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8600357 [details]
wip
Some concerns in the test but simple enough, I think. Thank you. :)
Attachment #8600357 -
Flags: feedback?(salva) → feedback+
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [s1]
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8600357 [details]
wip
Hei Salva,
could you take a second look, I added the modifications, but for any reason I'm not able to run Firefox Nightly tests on Mac OS.
Attachment #8600357 -
Flags: feedback?(salva)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8600357 [details]
wip
Hei Salva,
just removed the NI, ready for r?
Attachment #8600357 -
Flags: feedback?(salva) → review?(salva)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8600357 [details]
wip
Please, address the comments on GitHub and you're done. We are not providing any solution for Chrome, so passing options remain Firefox only.
Thanks for the work!
Attachment #8600357 -
Flags: review?(salva) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Landed:
https://github.com/arcturus/serviceworkerware/commit/2a30d161f0fe2c16a8442c8d8fc9727ea68dbc81
Chrome won't benefit from this yet, but will be, since the specs contains the matching options, so, hopefully, one day Chrome will honor that parameter too.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•