Closed Bug 1162918 Opened 10 years ago Closed 10 years ago

[Stingray][Home] Animation of moving card down to folder list is buggy when cardManager is longer than screen

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1158665 +++ STR: 1.Create cards on home such that cards occupy longer than screen. 2.Arrange an empty folder to the rightmost side of the list. 3.Put a card into the folder Expected: 4e. The card moves straightly down to the folder list Actual: 4a. The card moves obliquely down to the folder list == And go continuously, 5. Put another card into the folder Expected: 6e. The card moves straightly down to the folder list Actual: 6a. The card moves curvedly down to the folder list
For the second case the cause should be scrollable._slide had overwritten the timing function. We shouldn't call _slide for cases other than pin-to-card. For the first case, I'm not pretty sure, but it may caused by transition is not removed correctly when a card is moved into empty folder list.
Assignee: nobody → yliao
Comment on attachment 8607402 [details] [gaia] begeeben:1162918_animation_of_moving_card > mozilla-b2g:master This is the fix without refactoring the original insert card logic. Guess we do the refactor work in another bug?
Attachment #8607402 - Flags: review?(rexboy)
Comment on attachment 8607402 [details] [gaia] begeeben:1162918_animation_of_moving_card > mozilla-b2g:master Although I think it's a good solution, but we've already coupled too much different cases inside insert/remove function of scrollable.js (which is not just caused by this patch) Let's pending this and do some possible refactor before the code of scrollable becoming a mess.
Attachment #8607402 - Flags: review?(rexboy)
Added some comments based on our face-to-face discussion. Please set review again once you've finished the changes. Thank you!
Comment on attachment 8607402 [details] [gaia] begeeben:1162918_animation_of_moving_card > mozilla-b2g:master Thanks! Changes were made according to the comments. Please feel free to suggest any additional refinements.
Attachment #8607402 - Flags: review?(rexboy)
Comment on attachment 8607402 [details] [gaia] begeeben:1162918_animation_of_moving_card > mozilla-b2g:master Looks good to me. Thanks a lot!
Attachment #8607402 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Manually merged into master. Thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: