Closed Bug 1165864 Opened 10 years ago Closed 9 years ago

[ServiceWorkers] Add a default middleware on the constructor for handling those requests that wont hit any middle ware

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: arcturus, Assigned: arcturus)

References

Details

(Whiteboard: [s2])

Attachments

(1 file)

PR
(deleted), text/x-github-pull-request
salva
: review+
Details
No description provided.
Blocks: nga-toolkit-service-workers
Whiteboard: [s2]
Assignee: nobody → francisco
Status: NEW → ASSIGNED
Attached file PR (deleted) —
I got some errors running the tests for simpleoffline, don't know if chrome change api or not, added new tests to support the new functionality. Salva can you take a look?
Attachment #8608828 - Flags: review?(salva)
Comment on attachment 8608828 [details] PR You have a couple of recommendations, please ask for my review once you're done. Thank you!
Attachment #8608828 - Flags: review?(salva)
Comment on attachment 8608828 [details] PR Second round
Attachment #8608828 - Flags: review?(salva)
Comment on attachment 8608828 [details] PR Ok. Looks well but take a last look at [1] and address the nits before merging. Thank you Francisco. [1] https://github.com/gaia-components/serviceworkerware/pull/19#discussion_r31250804
Attachment #8608828 - Flags: review?(salva) → review+
Francisco! Per Johan PR [1], I realized latest versions of mocha allow to return promises instead of using `done()`. Maybe you want to change that and ask for review to Johan. [1] https://github.com/gaia-components/serviceworkerware/pull/16/files#diff-15d60247d5ae9010c43fef69ccd05488R68
(In reply to Salvador de la Puente González [:salva] from comment #5) > Francisco! Per Johan PR [1], I realized latest versions of mocha allow to > return promises instead of using `done()`. Maybe you want to change that and > ask for review to Johan. > > [1] > https://github.com/gaia-components/serviceworkerware/pull/16/files#diff- > 15d60247d5ae9010c43fef69ccd05488R68 Good point, will leave that for another PR, since want to land this.
Comments addressed and landed: https://github.com/gaia-components/serviceworkerware/commit/021ac35425d7c13ccbb2309c4d01fd64a92edc0f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: