Closed
Bug 1166684
Opened 10 years ago
Closed 10 years ago
[Stingray][Dashboard] Embed weather widget into dashboard
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: rexboy)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(2 files)
Embed weather widget into dashboard.
1. Open permission for dashboard that is required to embed widget.
2. Set dashboard as in-process app since the layered OOP hasn't complete yet.
3. We may need some modules/managers for managing widget in dashboard.
4. Dashboard also need to tell its widget whether it is expanded or not. Maybe through hash or IAC or something. But this can be solved in another bug.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rexboy
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
John and Yifan may you review this patch? Thanks!
Attachment #8609309 -
Flags: review?(yliao)
Attachment #8609309 -
Flags: review?(im)
Comment 3•10 years ago
|
||
Comment on attachment 8609309 [details]
Patch
Cool! Looks good to me. Let's keep it as simple as possible.
Attachment #8609309 -
Flags: review?(im) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8609309 [details]
Patch
Thanks! r+ with a newline missing.
Attachment #8609309 -
Flags: review?(yliao) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thank you guys!
master
https://github.com/mozilla-b2g/gaia/commit/bf4453575705e1fd37d1e18eac7f16b4957b0d63
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•