Closed Bug 1168068 Opened 10 years ago Closed 10 years ago

GonkGPSGeolocationProvider should use mRilDataServiceId in SetReferenceLocation

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1168068 - GonkGPSGeolocationProvider should use mRilDataServiceId in SetReferenceLocation. r=garvank
(deleted), text/x-review-board-request
garvan
: review+
Details
No description provided.
Attached file MozReview Request: bz://1168068/kanru (obsolete) (deleted) —
/r/9335 - Bug 1168068 - GonkGPSGeolocationProvider should use mRilDataServiceId in SetReferenceLocation. r=garvank Pull down this commit: hg pull -r f670ebf7a54fbaf952e228bdb802c4013b3586d0 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8610077 [details] MozReview Request: bz://1168068/kanru /r/9335 - Bug 1168068 - GonkGPSGeolocationProvider should use mRilDataServiceId in SetReferenceLocation. r=garvank Pull down this commit: hg pull -r f670ebf7a54fbaf952e228bdb802c4013b3586d0 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8610077 - Flags: review?(gkeeley)
Comment on attachment 8610077 [details] MozReview Request: bz://1168068/kanru https://reviewboard.mozilla.org/r/9333/#review8101 LGTM. Do you know how this and bug 772750 can get tested?
Attachment #8610077 - Flags: review?(gkeeley) → review+
Blocks: 772750
(In reply to Garvan Keeley [:garvank] from comment #3) > Comment on attachment 8610077 [details] > MozReview Request: bz://1168068/kanru > > https://reviewboard.mozilla.org/r/9333/#review8101 > > LGTM. Do you know how this and bug 772750 can get tested? I only test this manually :/ We could probably add a mock gps interface and write some gtests. I'll file new bugs.
Assignee: nobody → kchen
https://hg.mozilla.org/mozilla-central/rev/09185b830a35
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8610077 - Attachment is obsolete: true
Attachment #8620357 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: