Closed
Bug 1171226
Opened 9 years ago
Closed 9 years ago
Reading heap snapshots is *really* slow
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
Screenshot of Instruments profile
Almost all time spent de-duplicating type names when creating DeserializedNodes.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
(In reply to Nick Fitzgerald [:fitzgen][:nf] from comment #1)
> Created attachment 8614964 [details] [diff] [review]
> WIP: Stop de-duplicating strings
Reading a heap snapshot of the full process is basically a perma-beachball without this patch. With this patch, it is only ~1500 ms.
There is something funky going on in the de-duping, resulting in quadratic behavior or some such, because it shouldn't take minutes long.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8614964 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8614981 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8614994 [details] [diff] [review]
Fix mozilla::devtools::UniqueStringHashPolicy::match for strings with the same prefix
Note: I ensured that the new test fails without the change.
Attachment #8614994 -
Flags: review?(jimb)
|
||
Updated•9 years ago
|
Attachment #8614994 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•