Closed
Bug 1171245
Opened 9 years ago
Closed 9 years ago
Include changes attributes in TabAttrModified event
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
I'm trying to write an event listener that fires only when the favicon of a tab changes. This is associated with the TabAttrModified event, but that also fires in other cases. So I added some details to the event that say which attributes changed.
Attachment #8614965 -
Flags: review?(ttaubert)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8614965 [details] [diff] [review]
patch
Review of attachment 8614965 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/tabbrowser.xml
@@ +1167,5 @@
> });
> this.mCurrentTab.dispatchEvent(event);
>
> + this._tabAttrModified(oldTab, []);
> + this._tabAttrModified(this.mCurrentTab, []);
Should dispatch that the "selected" attribute changed here.
Attachment #8614965 -
Flags: review?(ttaubert) → review+
|
||
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•