Closed
Bug 1171294
Opened 9 years ago
Closed 9 years ago
NS_ENSURE_TRUE(piTarget) failed shows up over 60,000 times in linux debug test logs
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In discussion w/ smaug he suggested we can remove the |NS_ENSURE_TRUE| [1] that is generating this message.
[1] https://hg.mozilla.org/mozilla-central/annotate/196d99aabc27/dom/events/EventDispatcher.cpp#l469
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8615018 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Attachment #8615018 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Do we what these events are and where they came from?
Perhaps we shouldn't have created them in the first place?
Flags: needinfo?(erahm)
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #3)
> Do we what these events are and where they came from?
> Perhaps we shouldn't have created them in the first place?
:smaug seemed to think it was e10s related (and not an issue).
Flags: needinfo?(erahm) → needinfo?(bugs)
|
|
||
Comment 5•9 years ago
|
||
Not an issue, but still something to check if possible.
As mats suggest, perhaps we shouldn't even try to dispatch these events.
Flags: needinfo?(bugs)
|
|
||
Comment 6•9 years ago
|
||
The volume is quite high so I figured it might be a performance issue.
|
|
||
Comment 7•9 years ago
|
||
Dispatching an event in JS to a single event target 10000 times takes about 10ms on my laptop, 170ms on Flame.
I assume those 60000 times are spread over the thousands of tests.
|
|
Assignee | |
Comment 8•9 years ago
|
||
(In reply to Olli Pettay [:smaug] (Reviewing overload, no new review requests before June 7, please) from comment #7)
> Dispatching an event in JS to a single event target 10000 times takes about
> 10ms on my laptop, 170ms on Flame.
>
> I assume those 60000 times are spread over the thousands of tests.
Correct, this was across all tests performed on a debug linux64 build.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•