Closed
Bug 1174140
Opened 9 years ago
Closed 9 years ago
Some service worker info properties are empty in the list of service workers shown by about:sw
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
FxOS-S2 (10Jul)
People
(Reporter: jaoo, Assigned: jaoo)
References
Details
Attachments
(1 file)
STR
- Open a page that registers a sw.
- Open about:sw
Expected
Service worker info properties have value.
Actual
Some of the properties are empty such as 'Current Worker URL' and 'Active Cache Name'.
Note: Everything is fine after quitting and starting the browser again. It happens also on B2G.
Feel free to move this bug to v2, or v3 please.
Updated•9 years ago
|
Blocks: nga-toolkit-service-workers
Assignee | ||
Comment 1•9 years ago
|
||
This seems a regression. I've been poking around but I'm a bit lost. Could you give me any hint please? Thanks!
Flags: needinfo?(amarchesini)
Comment 4•9 years ago
|
||
I spoke with jaoo on IRC. Soon we will have a patch for this bug.
Flags: needinfo?(amarchesini)
Updated•9 years ago
|
Assignee: nobody → jaoo
Target Milestone: --- → FxOS-S2 (10Jul)
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
While working on other about:sw issues I've noticed that this issue reproduces when about:sw loads in the parent process. about:sw should load always on the child process when e10s mode is on. What could cause about:sw page to not load in the child process when e10s mode is on?
Comment 6•9 years ago
|
||
Bug 1155153 covers making about:sw work well in e10s...
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #6)
> Bug 1155153 covers making about:sw work well in e10s...
I'm aware bug 1155153 covered that (it added the URI_CAN_LOAD_IN_CHILD flag for about:sw page) but the thing is that I'm printing the pid of the calling process at ServiceWorkerManager::PropagateSoftUpdate() and sometimes I see the pid of the parent process (even if e10s mode is on). When that happens the issue in this bug reproduces.
Comment 8•9 years ago
|
||
Hmm, I thought URI_CAN_LOAD_IN_CHILD is enough to make the about page load in the child process...
Bill, is that not the case?
Flags: needinfo?(wmccloskey)
You additionally need to set URI_MUST_LOAD_IN_CHILD. Otherwise it will load in the parent if the current tab is already running in the parent.
Flags: needinfo?(wmccloskey)
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Bill McCloskey (:billm) from comment #9)
> You additionally need to set URI_MUST_LOAD_IN_CHILD. Otherwise it will load
> in the parent if the current tab is already running in the parent.
I just set that flag and it seems the issue is fixed. The missing properties are back now. I'll add this flag and attach a patch here. Thanks!
Assignee | ||
Comment 11•9 years ago
|
||
Bug 1174140 - Some service worker info properties are empty in the list of service workers shown by about:sw. r=billm
Attachment #8630349 -
Flags: review?(wmccloskey)
Comment on attachment 8630349 [details]
MozReview Request: Bug 1174140 - Some service worker info properties are empty in the list of service workers shown by about:sw. r=billm
https://reviewboard.mozilla.org/r/12707/#review11303
Ship It!
Attachment #8630349 -
Flags: review?(wmccloskey) → review+
Comment 13•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Comment 14•9 years ago
|
||
Comment 15•9 years ago
|
||
Hi,
Just checked on m-c (9b902b7669ae revision) in Nightly and all the following info properties are currently properly shown in about:sw once the sw is registered:
* "Scope"
* "Script Spec"
* "Current Worker URL"
* "Active Cache Name"
once an update process is launched, "Waiting Cache Name" property is also properly shown in about:sw
a new property called "Push Endpoint" is now appearing with "Waiting..." value. We will dig into this new property and try to check its behavior once we know how it should work
I'll check it on b2g once Bug 1181351 lands. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•