Closed
Bug 1174504
Opened 9 years ago
Closed 9 years ago
logical-coordinate versions of nsIFrame::SetSize should maintain the frame's logical position
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
When changing a frame's size using logical coordinates, it makes more sense for the frame's logical position to stay unchanged, rather than its physical origin.
Fixing this doesn't currently affect any reftests (https://treeherder.mozilla.org/#/jobs?repo=try&revision=c011056def55), but will be helpful during the conversion of table layout (which is what brought it to my attention).
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8622047 -
Flags: review?(smontagu)
Comment 2•9 years ago
|
||
Comment on attachment 8622047 [details] [diff] [review]
Logical-coordinate versions of nsIFrame::SetSize should maintain the frame's logical position
Review of attachment 8622047 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, this looks good, and as far as I can tell there aren't any callers of SetSize that already do this (a concern I brought up on IRC)
Attachment #8622047 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•