Closed Bug 1175033 Opened 9 years ago Closed 7 years ago

support custom use counters that can be incremented from C++

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox41 --- affected
firefox57 --- fixed

People

(Reporter: heycam, Assigned: ayg)

References

Details

Attachments

(1 file)

Once we have the basic use counter infrastructure in bug 968923 available, we should extend it to support "custom" use counters, which would be those which don't get automatically generated counter-incrementing code. You'd use custom use counters for cases where triggering simply on a method call or DOM property access or CSS property use is not sufficient. Otherwise you'd have to write the Telemetry stuff manually and make sure you get the same page/document counting as the built-in use counters right.
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Attachment #8894909 - Flags: review?(bzbarsky) → review?(nfroyd)
Comment on attachment 8894909 [details] Bug 1175033 - Support custom use counters that can be incremented from C++; https://reviewboard.mozilla.org/r/166064/#review172854 This is about as straightforward as these things get. ::: commit-message-52285:3 (Diff revision 1) > +I didn't add any special API, but the existing one doesn't seem too bad. > +Perhaps it could be named more nicely. > + > +I didn't test this beyond defining a custom use counter and verifying > +that Firefox compiled and started. Nit: this is not really a commit message, more of a message to the reviewer. Could you please remove these lines or write a better commit message?
Attachment #8894909 - Flags: review?(nfroyd) → review+
I know Luke was recently asking about this sort of stuff, this patch may be relevant to his interests.
Flags: needinfo?(luke)
Thanks!
Flags: needinfo?(luke)
Comment on attachment 8894909 [details] Bug 1175033 - Support custom use counters that can be incremented from C++; https://reviewboard.mozilla.org/r/166064/#review173090 ::: commit-message-52285:3 (Diff revision 1) > +I didn't add any special API, but the existing one doesn't seem too bad. > +Perhaps it could be named more nicely. > + > +I didn't test this beyond defining a custom use counter and verifying > +that Firefox compiled and started. Yeah, the problem is MozReview doesn't have a good place to put comments for the reviewer (I think?). I'll just remove them.
Pushed by ayg@aryeh.name: https://hg.mozilla.org/integration/autoland/rev/e894fa698629 Support custom use counters that can be incremented from C++; r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Yep, thanks! I filed a follow-up.
Flags: needinfo?(ayg)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: