Closed
Bug 1175033
Opened 9 years ago
Closed 7 years ago
support custom use counters that can be incremented from C++
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: heycam, Assigned: ayg)
References
Details
Attachments
(1 file)
Once we have the basic use counter infrastructure in bug 968923 available, we should extend it to support "custom" use counters, which would be those which don't get automatically generated counter-incrementing code. You'd use custom use counters for cases where triggering simply on a method call or DOM property access or CSS property use is not sufficient. Otherwise you'd have to write the Telemetry stuff manually and make sure you get the same page/document counting as the built-in use counters right.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Updated•7 years ago
|
Attachment #8894909 -
Flags: review?(bzbarsky) → review?(nfroyd)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8894909 [details]
Bug 1175033 - Support custom use counters that can be incremented from C++;
https://reviewboard.mozilla.org/r/166064/#review172854
This is about as straightforward as these things get.
::: commit-message-52285:3
(Diff revision 1)
> +I didn't add any special API, but the existing one doesn't seem too bad.
> +Perhaps it could be named more nicely.
> +
> +I didn't test this beyond defining a custom use counter and verifying
> +that Firefox compiled and started.
Nit: this is not really a commit message, more of a message to the reviewer. Could you please remove these lines or write a better commit message?
Attachment #8894909 -
Flags: review?(nfroyd) → review+
Comment 3•7 years ago
|
||
I know Luke was recently asking about this sort of stuff, this patch may be relevant to his interests.
Flags: needinfo?(luke)
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8894909 [details]
Bug 1175033 - Support custom use counters that can be incremented from C++;
https://reviewboard.mozilla.org/r/166064/#review173090
::: commit-message-52285:3
(Diff revision 1)
> +I didn't add any special API, but the existing one doesn't seem too bad.
> +Perhaps it could be named more nicely.
> +
> +I didn't test this beyond defining a custom use counter and verifying
> +that Firefox compiled and started.
Yeah, the problem is MozReview doesn't have a good place to put comments for the reviewer (I think?). I'll just remove them.
Comment hidden (mozreview-request) |
Pushed by ayg@aryeh.name:
https://hg.mozilla.org/integration/autoland/rev/e894fa698629
Support custom use counters that can be incremented from C++; r=froydnj
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 9•7 years ago
|
||
Do we need any updates to the documentation for this?
It lives here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/collection/use-counters.rst
https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/collection/use-counters.html
Flags: needinfo?(ayg)
Assignee | ||
Comment 10•7 years ago
|
||
Yep, thanks! I filed a follow-up.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ayg)
You need to log in
before you can comment on or make changes to this bug.
Description
•