Closed
Bug 117927
Opened 23 years ago
Closed 23 years ago
remove unused static variables in editor, netwerk, layout, content
Categories
(Core :: DOM: Editor, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: Brade, Assigned: Brade)
Details
Attachments
(1 file)
(deleted),
patch
|
darin.moz
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This bug is to cover removal of unused static variables in mozilla/editor
r=glazou; rs=shaver
Assignee | ||
Comment 1•23 years ago
|
||
272 bytes removed from data today; more to come on another day
Status: NEW → ASSIGNED
Assignee | ||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.8
Assignee | ||
Comment 2•23 years ago
|
||
darin has given me an rs= for mozilla/netwerk
Summary: remove unused static variables in editor → remove unused static variables in editor, netwerk, layout, content
Assignee | ||
Comment 3•23 years ago
|
||
A quick first pass of netwerk files found 345 bytes of unused static variables
or constants. They are now checked in.
Comment 4•23 years ago
|
||
I'm not sure what you're using to find these, but one easy way to find them is
to look at the warnings given by the IRIX native compiler. Problem is, the one
on tinderbox (cement on Seamonkey-Ports) is a depend build, so you need to get a
good log after someone causes a full rebuild. (However, the IRIX compiler won't
warn about ones that aren't declared |static|.)
Assignee | ||
Comment 5•23 years ago
|
||
A quick pass at mozilla/layout found 465 bytes which have now been removed.
dbaron--I am using the link map file on Mac (produced with CodeWarrior).
Assignee | ||
Comment 6•23 years ago
|
||
I have 643 bytes of data that can be removed in mozilla/content...
Assignee | ||
Comment 7•23 years ago
|
||
Comment 8•23 years ago
|
||
Comment on attachment 64168 [details] [diff] [review]
removal of unused static/globals in mozilla/content
Nice, sr=jst
Attachment #64168 -
Flags: superreview+
Comment 9•23 years ago
|
||
Comment on attachment 64168 [details] [diff] [review]
removal of unused static/globals in mozilla/content
r/sr=darin
Attachment #64168 -
Flags: review+
Assignee | ||
Comment 10•23 years ago
|
||
resolving this bug as fixed; there are more to be removed but they get slightly
trickier (they'll have to wait for another bug)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 11•23 years ago
|
||
Kathy, please verify this one...thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•