Closed
Bug 118509
Opened 23 years ago
Closed 23 years ago
[FIX]<input type="file"> is messed up/broken in RTL context
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: blanchardmatthew, Assigned: rods)
References
Details
(Keywords: rtl)
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
dcone
:
review+
attinasi
:
superreview+
shaver
:
approval+
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7) Gecko/20011221
BuildID: 2001122106
The file upload form control (<input type="file">) is messed up, and thus
broken, when directionality is right-to-left (as in <div dir="rtl">).
* The control doesn't respond to mouse events. e.g. you can't click the "browse"
button to select a file.
* Sometimes the "browse" button doesn't appear at all.
* The visual appearance of the control (which consists of a "browse" button and
a text field) is messed up.
Reproducible: Always
Steps to Reproduce:
1. HTML example: <div dir="rtl"><input type="file"></div>
2.
3.
Actual Results: (listed above)
Expected Results: There should appear a "browse" button and a text field side
by side. The user should be able to click the "browse" button to select a file.
HTML example:
<div dir="rtl">
<input type="file">
</div>
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
Confirmed. (BuildID: 2002 01 08 03/Win98).
/jc
Comment 3•23 years ago
|
||
The button is in fact misplaced just under the textbox. Better testcase coming.
Comment 4•23 years ago
|
||
2nd testcase, now you could see a little part of the button under the textbox.
Comment 5•23 years ago
|
||
confirming and reassigning
Assignee: alexsavulov → rods
Component: Form Submission → HTML Form Controls
QA Contact: vladimire → madhur
Comment 6•23 years ago
|
||
Confirmed with build: 2002021203 OS:WinNT
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 7•23 years ago
|
||
Nominating for nsbeta1, it is unusable without this fix.
1) I changed the second reflow so it is just adjusting for height and not
width.
2) It will skip the re-arranging of the erframes when in RTL
3) Will always re-arrange the frames when in RTL.
Assignee | ||
Updated•23 years ago
|
Summary: <input type="file"> is messed up/broken in RTL context → [FIX]<input type="file"> is messed up/broken in RTL context
Comment 9•23 years ago
|
||
Comment on attachment 70734 [details] [diff] [review]
patch
r=dcone
I wonder about this line..
buttonRect.x = 0;
Attachment #70734 -
Flags: review+
Comment 10•23 years ago
|
||
Comment on attachment 70734 [details] [diff] [review]
patch
sr=attinasi
Attachment #70734 -
Flags: superreview+
Assignee | ||
Comment 11•23 years ago
|
||
Don has a valid comment I changed it to:
buttonRect.x = aReflowState.mComputedBorderPadding.left;
Comment on attachment 70734 [details] [diff] [review]
patch
a=shaver for 0.9.9.
Attachment #70734 -
Flags: approval+
Assignee | ||
Comment 13•23 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 14•23 years ago
|
||
Verified. Looks good to me on trunk build 03-08.
If anyone is still seeing this problem, feel free to reopen this bug.
Status: RESOLVED → VERIFIED
Comment 15•23 years ago
|
||
*** Bug 58622 has been marked as a duplicate of this bug. ***
Comment 16•23 years ago
|
||
*** Bug 126137 has been marked as a duplicate of this bug. ***
Comment 17•23 years ago
|
||
*** Bug 81650 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 18•23 years ago
|
||
There's a tiny problem here.
Have you noticed the horizontal scrollbar?
When I view the attached testcases (in both Win98 and Linux, different build
numbers) I get a horizontal scrollbar. It vanishes when I click it or resize the
window.
Comment 19•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•