There's currently a ~3px gap between the caption buttons and the toolbar. We should fill that by just extending the box of the hover effect (see mock)

Should be fixed now.

Actually it looks like bug 1355764 fixed this only in non-maximized windows...

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review151742 ::: browser/base/content/browser-tabsintitlebar.js:216 (Diff revision 1) > + if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") && !menuHeight) { > + $("titlebar-buttonbox").style.height = fullTabsHeight + "px"; > + titlebarContentHeight = rect(titlebarContent).height; > + } else { > + $("titlebar-buttonbox").style.removeProperty("height"); > + } I'd suggest rearranging this as follows: if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { if (!menuHeight) { $("titlebar-buttonbox").style.height = fullTabsHeight + "px"; titlebarContentHeight = rect(titlebarContent).height; } else { $("titlebar-buttonbox").style.removeProperty("height"); } } Also, setting style.height would invalidate layout and then rect(titlebarContent) would flush layout, which is not ideal performance-wise. See the comments earlier in this code: // Try to avoid reflows in this code by calculating dimensions first and // then later set the properties affecting layout together in a batch. ... // Begin setting CSS properties which will cause a reflow How about: titlebarContentHeight = Math.max(titlebarContentHeight, fullTabsHeight);

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review151742 > I'd suggest rearranging this as follows: > > if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { > if (!menuHeight) { > $("titlebar-buttonbox").style.height = fullTabsHeight + "px"; > titlebarContentHeight = rect(titlebarContent).height; > } else { > $("titlebar-buttonbox").style.removeProperty("height"); > } > } > > Also, setting style.height would invalidate layout and then rect(titlebarContent) would flush layout, which is not ideal performance-wise. See the comments earlier in this code: > > // Try to avoid reflows in this code by calculating dimensions first and > // then later set the properties affecting layout together in a batch. > > ... > > // Begin setting CSS properties which will cause a reflow > > > How about: > > titlebarContentHeight = Math.max(titlebarContentHeight, fullTabsHeight); I moved code before `titlebarContentHeight`, to avoid double calculations. and also i did change to `min-height`, because in normal window, titlebar buttons icons have shrunk with `height`.

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review151972 ::: browser/base/content/browser-tabsintitlebar.js:176 (Diff revision 2) > fullMenuHeight = verticalMargins(menuStyles) + menuHeight; > } > > +#ifdef MOZ_PHOTON_THEME > + if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { > + if(!menuHeight) { nit: add a space after 'if' ::: browser/base/content/browser-tabsintitlebar.js:177 (Diff revision 2) > } > > +#ifdef MOZ_PHOTON_THEME > + if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { > + if(!menuHeight) { > + $("titlebar-buttonbox").style.minHeight = fullTabsHeight + "px"; Setting style.minHeight invalidates layout, and the following rect(titlebarContent) call will flush layout again. That's exactly the performance pitfall we should avoid. Did my titlebarContentHeight = Math.max(titlebarContentHeight, fullTabsHeight); suggestion not work out?

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review152002 ::: browser/base/content/browser-tabsintitlebar.js:176 (Diff revision 3) > fullMenuHeight = verticalMargins(menuStyles) + menuHeight; > } > > +#ifdef MOZ_PHOTON_THEME > + if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { > + if (!menuHeight && window.windowState == window.STATE_MAXIMIZED) { Now only set height when window is maximized, is this better?

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review152140 ::: browser/base/content/browser-tabsintitlebar.js:177 (Diff revisions 2 - 3) > } > > #ifdef MOZ_PHOTON_THEME > if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) { > - if(!menuHeight) { > - $("titlebar-buttonbox").style.minHeight = fullTabsHeight + "px"; > + if (!menuHeight && window.windowState == window.STATE_MAXIMIZED) { > + $("titlebar-buttonbox").style.height = fullTabsHeight + "px"; This needs to happen after the "// Begin setting CSS properties" comment below. See my previous remark about invalidating layout.

(In reply to UK92 from comment #7) > and also i did change to `min-height`, because in normal window, titlebar > buttons icons have shrunk with `height`. Is this not an issue anymore with your latest patch?

No, it's fixed with `Math.max(titlebarContentHeight, fullTabsHeight)`.

Comment on attachment 8875929 [details] Bug 1185482 - Remove gap between titlebar buttons and navigation toolbar https://reviewboard.mozilla.org/r/147328/#review152148 Looks good. Thanks!

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42f53d05f6f1 Remove gap between titlebar buttons and navigation toolbar r=dao

Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/7f16a9ed93a6 Backed out changeset 42f53d05f6f1 for breaking eslint because it tries to validate a file which needs preprocessing. r=backout on a CLOSED TREE

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/806cf3746d11 Remove gap between titlebar buttons and navigation toolbar r=dao

I think this patch broke the minimize button when the window is not maximized. Also the close button looks weird compared to other Windows apps. See: https://i.imgur.com/g3IZBQq.png (Today's Nightly vs Paint, both not maximized)

This patch also created a small space at the top of the tabs and because of that you can't switch between them when you click at the top: https://puu.sh/whTSU/d1a831cffb.gif (BAD) https://puu.sh/whU0q/fdd9ae580f.gif (GOOD)

Verified as fixed on latest Nightly version 56.0a1, Build ID 20170704030203 on Windows 10 and Mac OS X 10.12.