Closed
Bug 1189758
Opened 9 years ago
Closed 9 years ago
FindMyDevice leaks findmydevice.retry-count observers
Categories
(Firefox OS Graveyard :: FindMyDevice, defect)
Tracking
(tracking-b2g:+)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Keywords: perf, regression, Whiteboard: [systemsfe])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1189004 +++
See the memory reports in bug 1189004 and also bug 1189004 comment 9: there is system app/findmydevice code that is leaking mozSettings observers with the setting findmydevice.retry-count.
|
Assignee | |
Comment 1•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #0)
> +++ This bug was initially created as a clone of Bug #1189004 +++
>
> See the memory reports in bug 1189004 and also bug 1189004 comment 9: there
> is system app/findmydevice code that is leaking mozSettings observers with
> the setting findmydevice.retry-count.
Correction after carefully checking the about:memory report, this is leaking in the FindMyDevice app.
There are two call sites:
- https://github.com/mozilla-b2g/gaia/blob/9a45076c37ad2139f25194613916af5efb55bbc7/apps/findmydevice/js/findmydevice.js#L174
- https://github.com/mozilla-b2g/gaia/blob/9a45076c37ad2139f25194613916af5efb55bbc7/apps/findmydevice/js/findmydevice.js#L596
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8642020 [details]
[gaia] lissyx:bug1189758 > mozilla-b2g:master
This should be enough, this way we should avoid leaking.
Attachment #8642020 -
Flags: review?(mgoodwin)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8642020 [details]
[gaia] lissyx:bug1189758 > mozilla-b2g:master
LGTM.
Thanks
Attachment #8642020 -
Flags: review?(mgoodwin) → review+
|
||
Updated•9 years ago
|
tracking-b2g:
--- → +
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•