Closed
Bug 1191966
Opened 9 years ago
Closed 8 years ago
If Menu toolbar is shown, then it causes additional indent on top of the window in Fullscreen mode
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | wontfix |
firefox47 | --- | wontfix |
firefox48 | --- | wontfix |
firefox49 | --- | verified |
firefox-esr38 | --- | unaffected |
People
(Reporter: arni2033, Assigned: xidorn)
References
(Blocks 1 open bug, )
Details
(Keywords: regression)
Attachments
(3 files)
STR: (Nightly 42.0a1 (2015-08-06))
1. Make sure you have hidden menu bar, bookmarks bar and title bar
2. Switch to Fullscreen mode
3. Press Alt several times
RESULT: [watch video]
Part of toolbar (some pixels in height) is visible on the top of the screen
EXPECTATIONS: one of 2 will happen:
A) Nothing
B) I will see all toolbars in their current states (as of non-fullscreen mode), including menu bar, that will be visible. When I press Alt again in this scenario, I expect all toolbars to hide again.
I figured out that it doesn't occur on Release(39), but presented on DevEdition(41) and Nightly(42).
Also, the problem is a bit more serious. STR_2:
1. Right-click Australis menu button -> check "Menu bar"
2. Press F11 to enter Fullscreen mode
RESULT: see attachment. It makes using tabs much more complicated.
Component: Menus → Toolbars and Customization
Keywords: regression
Summary: Pressing ALT in Fullscreen mode causes part of toolbar to appear → If Menu toolbar is shown, then it causes additional indent on top of the window in Fullscreen mode
Comment hidden (obsolete) |
Severity: normal → minor
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox43:
--- → affected
status-firefox-esr38:
--- → unaffected
Keywords: regressionwindow-wanted
Keywords: regressionwindow-wanted
Pay attention that now bug 1192655 is fixed, so only STR in comment 1 works. But this bug is still valid
Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3fca18104696e85d3f90c84802e03479b9c023ee&tochange=4b47c3f074a36bb16295bf3127268094a64ed7db
I think it's bug 1176233.
Blocks: 1176233
Flags: needinfo?(dao)
Assignee | ||
Comment 5•9 years ago
|
||
This is because the gap was added via the rule:
> #toolbar-menubar:not([moz-collapsed="true"]):not([autohide="true"]) ~ #TabsToolbar {
> margin-top: 3px;
> }
And since bug 1176233, we no longer use moz-collapsed for collapsing toolbars.
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54506/
Attachment #8755276 -
Flags: review?(dao+bmo)
Attachment #8755277 -
Flags: review?(dao+bmo)
Assignee | ||
Comment 7•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54508/
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bugzilla
Comment 8•9 years ago
|
||
Comment on attachment 8755276 [details]
MozReview Request: Bug 1191966 part 1 - Remove rules for unused moz-collapsed attribute. r?dao
We need to keep moz-collapsed support in minimal-xul.css, it's used by add-ons.
Flags: needinfo?(dao+bmo)
Attachment #8755276 -
Flags: review?(dao+bmo) → review-
Comment 9•9 years ago
|
||
Comment on attachment 8755277 [details]
MozReview Request: Bug 1191966 part 2 - Avoid adding margin-top on tabs toolbar when in fullscreen mode. r?dao
Please use #TabsToolbar:not([inFullscreen])
Attachment #8755277 -
Flags: review?(dao+bmo) → review-
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8755276 [details]
MozReview Request: Bug 1191966 part 1 - Remove rules for unused moz-collapsed attribute. r?dao
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54506/diff/1-2/
Attachment #8755276 -
Flags: review- → review?(dao+bmo)
Attachment #8755277 -
Flags: review- → review?(dao+bmo)
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8755277 [details]
MozReview Request: Bug 1191966 part 2 - Avoid adding margin-top on tabs toolbar when in fullscreen mode. r?dao
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54508/diff/1-2/
Updated•9 years ago
|
Attachment #8755276 -
Flags: review?(dao+bmo) → review+
Updated•9 years ago
|
Attachment #8755277 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/af0b7a2ad92a
https://hg.mozilla.org/integration/fx-team/rev/ef5addc3db7d
Keywords: checkin-needed
Assignee | ||
Comment 13•8 years ago
|
||
This seems to have been landed on mozilla-central a while ago. Not sure why the bug is not updated.
https://hg.mozilla.org/mozilla-central/rev/af0b7a2ad92a
https://hg.mozilla.org/mozilla-central/rev/ef5addc3db7d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox40:
affected → ---
status-firefox41:
affected → ---
status-firefox42:
affected → ---
status-firefox43:
affected → ---
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
Blocks: fx-fullscreen
Comment 14•8 years ago
|
||
bugherder |
Updated•8 years ago
|
Comment 15•8 years ago
|
||
I have reproduced this bug with Nightly 42.0a1 (2015-08-06) on Windows 7 , 64 Bit!
This bug's fix is verified on latest Developer Edition (Aurora) which is 49.0a2 (2016-07-08).
Build ID 20160708004052
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 16•8 years ago
|
||
Thanks Maruf Rahman for the tests.
I was also not able to reproduce this issue on Firefox 49.0a2 (2016-07-10) and on Windows 7 x86.
I am marking this issue Verified Fixed.
Status: RESOLVED → VERIFIED
Too late to bring to beta, but this will be fixed in 49 release.
You need to log in
before you can comment on or make changes to this bug.
Description
•