[1.Description]: [Aries KK v2.5][Flame KK v2.2 & v2.5][Contacts]Launch Contacts app and export contacts from device to China Unicom USIM card(128K)/China Mobile SIM card (128K), after exporting 50~110 contacts, it will prompt: SIM card is full. See attachment: AriesKK2.5_video.3gp & logcat_AriesKK2.5_1648.txt Found time: 16:48 [2.Testing Steps]: Precondition: a. There're more than 100 contacts in device. b. Insert a China Unicom USIM card(128K) or China Mobile SIM card(128K) in device and there's no contacts in SIM card. 1. Launch Contacts APP. 2. Tap Settings gear icon. 3. Tap "Export" and select SIM card. 4. Select some contacts and begin to export them to SIM card. [3.Expected Result]: 4. It could export 500 contacts from device to China Unicom USIM card(128K)/China Mobile SIM card (128K). [4.Actual Result]: 4. It only can export 50~110 contacts from device to SIM card, after exporting 50~110 contacts, it will prompt: SIM card is full. [5.Reproduction build]: Device: Aries KK 2.5(Affected) Build ID 20150811234258 Gaia Revision c7875bbc8b32e7b95cc55c9690b03b140905d84d Gaia Date 2015-08-11 18:18:36 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/d4f3a8a75577e4af2914a4e899ca2e724f9715c4 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150811.230622 Firmware Date Tue Aug 11 23:06:29 UTC 2015 Bootloader s1 Device: Flame KK 2.2(Affected) Build ID 20150812032504 Gaia Revision 102f1299e9eafe3760e1deb44d556b5c4f36b5af Gaia Date 2015-08-06 20:46:56 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9295034c0ee3 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150812.065135 Firmware Date Wed Aug 12 06:51:47 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Flame KK 2.5(Affected) Build ID 20150812150204 Gaia Revision 52f3ea58df38e5427f6afeb636bc6ad01d24022f Gaia Date 2015-08-12 16:40:43 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/cf932fc931dcd19f425934db79bec641ebe2a8a9 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150812.182303 Firmware Date Wed Aug 12 18:23:12 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,10/10 [7.TCID]: 9888

As Firefox OS doesn't allow the deletion of contacts on the SIM cards, I wonder if the SIM card wasn't already filled with contacts. Shine, could you tell how many contacts there are in the SIM card before the bug and then after it?

Hi Johan, Before the bug, I have inserted the SIM card into HTC device and deleted all the contacts in the SIM card, so there's no contact actually in the SIM card. After this bug, I inserted this SIM card into HTC device again and tried to create contacts to SIM, and it supported up to 500 contacts. Hope this is valuable for you. Many thanks!

I don't see any ICC error in the logs. Would a RIL logcat help to identify the issue?

A ril logcat will help, and once we have it definitely Yoshi could tell us more (I hope :))

forward to Hsinyi's team

Shine, could you get a logcat with RIL debugging enabled[1]? [1] https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#RIL_Debugging

Hi Johan, I have provided the logcat with RIL debugging enabled on latest build of Aries KK v2.5. Please refer to: logcat_AriesKK2.5_1017.txt Found time: 10:17 Aries KK 2.5 Build ID: 20150818233027 Thanks!

Thanks Shine. The error is a problem of memory: > 08-19 10:17:28.214 I/Gecko ( 318): -*- RadioInterface[0]: Received message from worker: {"contactType":0,"contact":{"contactId":"null","alphaId":"Chisholm","number":"1-361-657-1321","email":"webmaster@contact.sohu.com","pbrIndex":0,"recordId":106},"pin2":null,"rilMessageClientId":0,"rilMessageToken":133,"rilMessageType":"updateICCContact","errorMsg":"NoFreeRecordFound"}

Hi John, could you please take a look?

The root cause is when sim card without sufficient Type 2 USIM contact fields, we throw an error and halt continue importing remainder contacts. Hi edgar, may I have your review for this fix? Thanks.

Based on patch.

Comment on attachment 8652246 [details] [diff] [review] Continue importing contacts when there is no sufficient Type 2 USIM contact fields record. Review of attachment 8652246 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +14628,2 @@ > } > + onsuccess(); Will the returned contact contain the field which is not actually updated successfully if we notify success here? ::: dom/system/gonk/tests/test_ril_worker_icc_ICCContactHelper.js @@ +607,5 @@ > }); > > /** > + * Verify ICCContactHelper.updateICCContact with appType is CARD_APPTYPE_USIM and > + insufficient space to store Type 2 USIM contact fields. Nit: * insufficient .... @@ +671,5 @@ > + // emulate email and anr don't have free record. > + if (fileId === EMAIL_FILE_ID || fileId === ANR0_FILE_ID) { > + onerror("NoFreeRecordFound"); > + } > + else { Nit: } else { @@ +679,5 @@ > + > + let isSuccess = false; > + let onsuccess = function onsuccess(updatedContact) { > + equal(ADN_RECORD_ID, updatedContact.recordId); > + equal(aContact.alphaId, updatedContact.alphaId); Add tests for the |updatedContact| shouldn't contain email and anr field.

(In reply to Edgar Chen [:edgar][:echen] from comment #13) > Comment on attachment 8652246 [details] [diff] [review] > Continue importing contacts when there is no sufficient Type 2 USIM contact > fields record. > > Review of attachment 8652246 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/ril_worker.js > @@ +14628,2 @@ > > } > > + onsuccess(); > > Will the returned contact contain the field which is not actually updated > successfully if we notify success here? Thanks for reminding this. I will address this in next patch. > > ::: dom/system/gonk/tests/test_ril_worker_icc_ICCContactHelper.js > @@ +607,5 @@ > > }); > > > > /** > > + * Verify ICCContactHelper.updateICCContact with appType is CARD_APPTYPE_USIM and > > + insufficient space to store Type 2 USIM contact fields. > > Nit: * insufficient .... Will do. > > @@ +671,5 @@ > > + // emulate email and anr don't have free record. > > + if (fileId === EMAIL_FILE_ID || fileId === ANR0_FILE_ID) { > > + onerror("NoFreeRecordFound"); > > + } > > + else { > > Nit: } else { > > @@ +679,5 @@ > > + > > + let isSuccess = false; > > + let onsuccess = function onsuccess(updatedContact) { > > + equal(ADN_RECORD_ID, updatedContact.recordId); > > + equal(aContact.alphaId, updatedContact.alphaId); > > Add tests for the |updatedContact| shouldn't contain email and anr field. Will do.

Addressing comment #13. Edgar, may I have your review on this? Thanks.

Comment on attachment 8658129 [details] [diff] [review] Continue importing contacts when there is no sufficient Type 2 USIM contact fields record. v2 Review of attachment 8658129 [details] [diff] [review]: ----------------------------------------------------------------- Thanks you.

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=973e8d8ca843

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. Actual results: It can export 500 contacts from device to China Unicom USIM card(128K)/China Mobile SIM card(128K). If you continue to export new contacts into SIM card after exporting 500 contacts to SIM, it also prompts "SIM card is full" as expected. See attachment: verified_Aries_v2.5.3gp Reproduce rate: 0/10 Device: Flame KK 2.5 (Pass) Build ID 20150917150223 Gaia Revision aede8622d780ec71f766a3ecccbff74c04aaba4e Gaia Date 2015-09-17 03:40:46 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/3929b8fc6c33bf9cc80299743063f0981f545452 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150917.183330 Firmware Date Thu Sep 17 18:33:40 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5 (Pass) Build ID 20150917232610 Gaia Revision 2082894c8e974b0c371e4dec298e0ad0f3ac56b1 Gaia Date 2015-09-17 14:56:47 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/01a75ffad1024a3f75d494fb77a022c96a497eb2 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150917.224608 Firmware Date Thu Sep 17 22:46:16 UTC 2015 Bootloader s1