Closed
Bug 1196644
Opened 9 years ago
Closed 9 years ago
Add OriginAttributes to PermissionSettings
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
FxOS-S8 (02Oct)
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: allstars.chh, Assigned: arroway)
References
Details
(Whiteboard: [userContextId][OA])
mentioned by bholley in
https://bugzilla.mozilla.org/show_bug.cgi?id=1165272#c11
::: dom/permission/PermissionSettings.js
@@ +36,5 @@
> PermissionSettings.prototype = {
> get: function get(aPermName, aManifestURL, aOrigin, aBrowserFlag) {
> debug("Get called with: " + aPermName + ", " + aManifestURL + ", " + aOrigin + ", " + aBrowserFlag);
> let uri = Services.io.newURI(aOrigin, null, null);
> let appID = appsService.getAppLocalIdByManifestURL(aManifestURL);
So, we're going to need to update all of this code to operate properly for signedPkg, right? Please file a blocker against bug 1163254 so that we remember to do this (both this stuff and the stuff in PermissionSettings.jsm)
|
||
Updated•9 years ago
|
Priority: -- → P2
Target Milestone: --- → FxOS-S8 (02Oct)
Assigning to stephanie for now.
Assignee: nobody → stephouillon
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
Discussed with Jonas, he suggested we should add another attribute like manifestURL into OriginAttributes or create another dictionary, since Gaia uses manifestURL instead of appId.
Summary: Add signPKg parameter into PermissionSettings.js jsm → Add OriginAttributes to PermissionSettings
|
|
Reporter | |
Updated•9 years ago
|
Component: Permission Manager → DOM
|
||
Updated•9 years ago
|
Blocks: createCodebasePrincipal
|
|
||
Updated•9 years ago
|
Whiteboard: [userContextId]
(In reply to Tanvi Vyas - out until 1/28 [:tanvi] from comment #3)
> Is this b2g specific? Dave, can you find out?
Yes - this the for the permissionSettings API (allows the settings app to change permissions for an origin)
|
|
||
Comment 5•9 years ago
|
||
I think because this is b2g specific, we no longer need to fix this? Paul can you confirm?
Flags: needinfo?(huseby) → needinfo?(ptheriault)
|
|
Reporter | |
Comment 6•9 years ago
|
||
agree.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(ptheriault)
Resolution: --- → WONTFIX
|
|
||
Updated•9 years ago
|
Whiteboard: [userContextId] → [userContextId][OA]
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•