Closed
Bug 1198246
Opened 9 years ago
Closed 9 years ago
Every page loading displays a favicon, then switches back to the pin icon, then displays a different icon
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cwiiis, Assigned: apastor)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Seems every page I browse to, I almost immediately get an icon, then that's almost again immediately replaced by the grey 'pin' icon, then when the page loads, it gets replaced by a proper icon again.
This looks and feels bad, we shouldn't be showing the pin icon in-between loading different site icons.
STR:
1- Browse to engadget.com
2- Observe the icon displayed in the rocketbar
Expected:
After the icon is loaded, it remains there. Perhaps it changes, but you don't see any 'default' icon after an icon has loaded.
Actual:
You see a favicon briefly, then you see the default 'pin' icon while the page loads. Eventually, you see another, different icon.
Video: http://youtu.be/gA9jQQGble8
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → apastor
Whiteboard: [systemsfe]
Comment 1•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8666771 [details]
[gaia] albertopq:1198246-site-icon-resize > mozilla-b2g:master
Instead of always loading the default icon on locationchange, we try to load the favicon first. In case it fails, we just set the backgroundImage to '' (and so the default icon will be loaded). Eric provided a new default icon, so I added it in this bug. Guillaume, could you please take a look? Thanks!
Attachment #8666771 -
Flags: review?(gmarty)
Comment 4•9 years ago
|
||
Comment on attachment 8666771 [details]
[gaia] albertopq:1198246-site-icon-resize > mozilla-b2g:master
Brilliant! Please optimise the SVG files via SVGO before merging (see comment on Github).
Thanks for fixing this very annoying bug.
Attachment #8666771 -
Flags: review?(gmarty) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•