Closed
Bug 1204007
Opened 9 years ago
Closed 8 years ago
Cross out permission icons in the control center when they have been blocked
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
People
(Reporter: bgrins, Assigned: gasolin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxprivacy])
Attachments
(4 files)
Icons in the permissions view in the control center should be crossed out if they are blocked. See https://mozilla.invisionapp.com/share/DM3XGA6YE#/screens/96290112.
Updated•9 years ago
|
Flags: qe-verify?
Reporter | ||
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Updated•9 years ago
|
Priority: P3 → P2
Updated•9 years ago
|
Priority: P2 → P3
Assignee | ||
Comment 1•9 years ago
|
||
could you help find the right person to provide permission icons?
Flags: needinfo?(agrigas)
Comment 2•9 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #1)
> could you help find the right person to provide permission icons?
yes, its bryan bell on the UX team
Flags: needinfo?(agrigas) → needinfo?(bbell)
(In reply to Fred Lin [:gasolin] from comment #1)
> could you help find the right person to provide permission icons?
the icons you need can be found in here
https://www.dropbox.com/sh/nscav5ttkzv5apy/AABKbOBzO2w1GkCxH_xycJkNa?dl=0
Flags: needinfo?(bbell)
Updated•9 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 5•8 years ago
|
||
As :paolo addressed in bug 1193006 comment 71, we need to take svg icon from 16x16 then transform and make it fit to 32x32
In this issue 32x32 svg does not contain `blocked` series of icons.
Could you help to bring them to 32x32?
Flags: needinfo?(bbell)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gasolin
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•8 years ago
|
||
Here's the screenshot when all SitePermissions set blocked as default
Assignee | ||
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61178/
Attachment #8766175 -
Flags: review?(paolo.mozmail)
Assignee | ||
Comment 8•8 years ago
|
||
Since popup icon does not contain `blocked-icon` version, I pick the same popup icon.
Comment 9•8 years ago
|
||
Comment on attachment 8766175 [details]
Bug 1204007 - show blocked icon in control center when they have been blocked;
https://reviewboard.mozilla.org/r/61178/#review58124
Looks good! In the meantime, just today in bug 1206252 Johann created a version of the blocked SVG icons generated procedurally. I've asked him to post it to this bug so you can just "hg pull" the MozReview changeset (with the command indicated near "Pull:" on the left of the MozReview interface) and then "hg rebase" your changeset on top of it.
::: browser/base/content/browser.js:7241
(Diff revision 1)
> - "identity-popup-permission-icon " + aPermission.id + "-icon");
> + "identity-popup-permission-icon " + aPermission.id + state + "-icon");
>
Add "blocked" as a separate class. Then...
::: browser/themes/shared/notification-icons.inc.css:79
(Diff revision 1)
> +.camera-blocked-icon,
> .geo-icon,
> +.geo-blocked-icon,
> .indexedDB-icon,
...you don't need to add these extra entries here, and...
::: browser/themes/shared/notification-icons.inc.css:123
(Diff revision 1)
> +.desktop-notification-blocked-icon {
> + list-style-image: url(chrome://browser/skin/glyphs.svg#desktop-notification-blocked);
> +}
> +
...you can use .desktop-notification-icon.blocked as a selector to change the list-style-image.
::: browser/themes/shared/notification-icons.inc.css:225
(Diff revision 1)
> +.popup-icon,
> +.popup-blocked-icon {
And you won't need the double selector here. Maybe add a comment for why this icon doesn't have a "blocked" version?
Attachment #8766175 -
Flags: review?(paolo.mozmail)
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61274/
Attachment #8766293 -
Flags: review?(paolo.mozmail)
Comment 11•8 years ago
|
||
There you go!
Comment 12•8 years ago
|
||
Comment on attachment 8766293 [details]
Bug 1204007 - Part 1: Add blocked permission icons to glyphs.svg.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61274/diff/1-2/
Updated•8 years ago
|
Attachment #8766293 -
Flags: review?(paolo.mozmail) → review+
Comment 13•8 years ago
|
||
Comment on attachment 8766293 [details]
Bug 1204007 - Part 1: Add blocked permission icons to glyphs.svg.
https://reviewboard.mozilla.org/r/61274/#review58138
Comment 14•8 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #8)
> Since popup icon does not contain `blocked-icon` version, I pick the same
> popup icon.
Actually, I missed this comment earlier. I think the reason why we don't show a strikethrough on this icon is that it has a "block" sign in it already, so this is what we should say in the comment.
Assignee | ||
Comment 15•8 years ago
|
||
Thanks for feedback! Here's the screenshot based on johann's svg modification
Flags: needinfo?(bbell)
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8766175 [details]
Bug 1204007 - show blocked icon in control center when they have been blocked;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61178/diff/1-2/
Attachment #8766175 -
Attachment description: Bug 1204007 - Show blocked icons in the control center when they have been blocked; → Bug 1204007 - show blocked icon in control center when they have been blocked;
Attachment #8766175 -
Flags: review?(paolo.mozmail)
Comment 17•8 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/fx-team/rev/a667fecb7613
Part 1 - Add blocked permission icons to glyphs.svg. r=paolo
https://hg.mozilla.org/integration/fx-team/rev/050c0ad48c78
Part 2 - Cross out permission icons in the Control Center when they have been blocked. r=paolo
Updated•8 years ago
|
Attachment #8766175 -
Flags: review?(paolo.mozmail) → review+
Comment 18•8 years ago
|
||
Note that I've fixed the missing "popup" icon in part 1 before landing it.
Comment 19•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a667fecb7613
https://hg.mozilla.org/mozilla-central/rev/050c0ad48c78
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Iteration: --- → 50.3 - Jul 18
Priority: P2 → P1
Assignee | ||
Comment 20•8 years ago
|
||
thanks!
Updated•8 years ago
|
QA Contact: paul.silaghi
Comment 21•8 years ago
|
||
Looks good, verified fixed on FX 50.0a1 (2016-07-07) Win 7, Ubuntu 14.04, OS X 10.11.
Anyway, I still have 2 observations:
1. Can't we somehow refresh live the control center when toggling between allow/block? Now you need to dismiss it and open again in order to see the permission icons changes
2. The blocked location permission on mac looks just like an arrow - http://i.imgur.com/NUhdRNd.png. Can't we use the round location icon from win/linux instead?
Assignee | ||
Comment 22•8 years ago
|
||
1. The UI change is worked in bug 1203292, the right side dropdown selector will be replaced to the simpler one, which doesn't need present the live icon change.
2. relay the 2nd question in comment 21 to designer
Flags: needinfo?(gasolin) → needinfo?(bbell)
You need to log in
before you can comment on or make changes to this bug.
Description
•