Closed
Bug 1207103
Opened 9 years ago
Closed 9 years ago
(Gaia RTL 2.5) CSS refactoring: value selectors
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(feature-b2g:2.5+)
RESOLVED
FIXED
feature-b2g | 2.5+ |
People
(Reporter: u550245, Assigned: kaze)
References
Details
Attachments
(1 file, 2 obsolete files)
Improve the RTL support of the System app by refactoring the stylesheets for these building blocks:
• date_selector
• time_selector
• value_selector
Comment 1•9 years ago
|
||
Hey Pavel, :-)
most of this patch should be a straight-forward CSS refactoring, to match our BiDi guidelines [1]. Main points worth noticing:
• time_selector, there was a typo in the `12hrev` format that had to be fixed in a couple JS files (trivial fix);
• date_selector, I’ve had to redo a rather big part of the stylesheet.
The date and time selectors aren’t just about mirroring rules from LTR to RTL, as some parts remain at the same position whatever the language direction is.
Attachment #8664178 -
Flags: review?(pivanov)
Updated•9 years ago
|
Blocks: CSS_Refactor_2.5
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kaze
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•9 years ago
|
||
Ooops, I posted this patch with the wrong bugzilla account. Sorry.
Attachment #8664177 -
Attachment is obsolete: true
Attachment #8664178 -
Attachment is obsolete: true
Attachment #8664178 -
Flags: review?(pivanov)
Attachment #8664183 -
Flags: review?(pivanov)
Comment 4•9 years ago
|
||
I left few comments in github ... but everything else looks good :) thanks r+
Updated•9 years ago
|
Attachment #8664183 -
Flags: review?(pivanov) → review+
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Assignee | ||
Comment 5•9 years ago
|
||
Comments addressed, commits squashed. Thanks Pavel! :)
Comment 6•9 years ago
|
||
Kazé,
Are we waiting for bug 1207131 to land this and similar bugs that have non-green tests?
Assignee | ||
Comment 7•9 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/405c72c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•