Need to replace non-standard expression closure with one of: * function declaration * function expression * arrow function before fixing bug 1083458. converting rules are following: * function declaration add `return` and braces * standalone named function expression add `return` and braces * standalone anonymous function expression contans and receives `this` (Array.filter, bind, etc) convert to arrow function, and remove code passing |this| * standalone anonymous function expression contans no `this` convert to arrow function * property with anonymous function expression, contains `this` add `return` and braces * property with anonymous function expression, contains no `this`, short body convert to arrow function * property with anonymous function expression, contains no `this`, long body add `return` and braces * property with named function expression add `return` and braces * getter property add `return` and braces * setter property add braces Since there are a lot of patches, separated into 8 bugs, each bug corresponds to one of following directories: * browser/, except browser/components/. * browser/components/. * dom/. * layout/. * services/. * toolkit/, except toolkit/components/. * toolkit/components/. * b2g/, chrome/, docshell/, mobiles/, modules/, netwerk/, parser/, security/, storage/, testing/, webapprt/, widget/, xpcom/ (not yet touched addon-sdk) I have draft patches, will post them (may take some time to prepare and post).

On second thought, changes under layout/ don't need to be separated into multiple patches, so only 1 patch for this bug. Almost green on try run: (with other patches, M(13) is not related) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c844b363eef3

Comment on attachment 8666789 [details] [diff] [review] Remove use of expression closure from layout/. r=me