Need to replace non-standard expression closure with one of: * function declaration * function expression * arrow function before fixing bug 1083458. converting rules are following: * function declaration add `return` and braces * standalone named function expression add `return` and braces * standalone anonymous function expression contans and receives `this` (Array.filter, bind, etc) convert to arrow function, and remove code passing |this| * standalone anonymous function expression contans no `this` convert to arrow function * property with anonymous function expression, contains `this` add `return` and braces * property with anonymous function expression, contains no `this`, short body convert to arrow function * property with anonymous function expression, contains no `this`, long body add `return` and braces * property with named function expression add `return` and braces * getter property add `return` and braces * setter property add braces Since there are a lot of patches, separated into 8 bugs, each bug corresponds to one of following directories: * browser/, except browser/components/. * browser/components/. * dom/. * layout/. * services/. * toolkit/, except toolkit/components/. * toolkit/components/. * b2g/, chrome/, docshell/, mobiles/, modules/, netwerk/, parser/, security/, storage/, testing/, webapprt/, widget/, xpcom/ (not yet touched addon-sdk) I have draft patches, will post them (may take some time to prepare and post).

Additional rule: * function expression, contains `arguments` add `return` and braces Almost green on try run: (with other patches, M(13) is not related) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c844b363eef3

Comment on attachment 8667190 [details] [diff] [review] Part 10: Remove use of expression closure from testing/. Review of attachment 8667190 [details] [diff] [review]: ----------------------------------------------------------------- thanks for writing this!

Comment on attachment 8667180 [details] [diff] [review] Part 3: Remove use of expression closure from docshell/. r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e6465169e40 https://hg.mozilla.org/integration/mozilla-inbound/rev/4cd9898b3410 https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0f8e4b15c8 https://hg.mozilla.org/integration/mozilla-inbound/rev/48898d8384d8 https://hg.mozilla.org/integration/mozilla-inbound/rev/31b39f0a34c1 https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9d7516ce42 https://hg.mozilla.org/integration/mozilla-inbound/rev/63b57083408f https://hg.mozilla.org/integration/mozilla-inbound/rev/89469953a96a https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b11364d743 https://hg.mozilla.org/integration/mozilla-inbound/rev/679b74f654b0 https://hg.mozilla.org/integration/mozilla-inbound/rev/56d7babc6147 https://hg.mozilla.org/integration/mozilla-inbound/rev/73d2fd0abd3f https://hg.mozilla.org/integration/mozilla-inbound/rev/056927c667ab https://hg.mozilla.org/integration/mozilla-inbound/rev/57ef7c720fda

https://hg.mozilla.org/mozilla-central/rev/3e6465169e40 https://hg.mozilla.org/mozilla-central/rev/4cd9898b3410 https://hg.mozilla.org/mozilla-central/rev/4c0f8e4b15c8 https://hg.mozilla.org/mozilla-central/rev/48898d8384d8 https://hg.mozilla.org/mozilla-central/rev/31b39f0a34c1 https://hg.mozilla.org/mozilla-central/rev/5e9d7516ce42 https://hg.mozilla.org/mozilla-central/rev/63b57083408f https://hg.mozilla.org/mozilla-central/rev/89469953a96a https://hg.mozilla.org/mozilla-central/rev/d5b11364d743 https://hg.mozilla.org/mozilla-central/rev/679b74f654b0 https://hg.mozilla.org/mozilla-central/rev/56d7babc6147 https://hg.mozilla.org/mozilla-central/rev/73d2fd0abd3f https://hg.mozilla.org/mozilla-central/rev/056927c667ab https://hg.mozilla.org/mozilla-central/rev/57ef7c720fda